Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp599272pxb; Thu, 19 Aug 2021 07:03:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtATmbwUc2JPmiZEw4BTUi/Eq4BzXbaE/2VI504GTg0AC0c+ovHLwhTfP2inYrQwA7Slqw X-Received: by 2002:a05:6402:64b:: with SMTP id u11mr17168347edx.4.1629381783252; Thu, 19 Aug 2021 07:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629381783; cv=none; d=google.com; s=arc-20160816; b=MAz7NCfGCeHN24vyaIP03fn0UF28b/CCvwFdrWpYQ6VmqXBmKT9BTrCpYw4MKPfdK7 hQc7cezwyvLdfiPTx01L7WPOhgCmPmQiQjGiRW9ilQBIqFFolbeIOVYc7jIA06TswJcc j7HwFDKootOq/P/bBumedWlW+nHRNwSM3NJpeovkrcN/fi97XKOy0hqJzkjXZS3jmqEZ cvr4FeQi+EbIToE4ruL7bj8aw0ql52vu4AwaKjL9I5i8Cf5AUO3BHVZxTwApQNqQZD78 dEX349sx5QfkK8ruS+JTxJXkiOydBebpNCFjRxrULZpDcDxIBG1sXA5UGssYy6zZffP2 uFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=vrgR/7Ax9Jv2ezbaP/CKQhrK7xJEFBCM3d5iboIQxZw=; b=hx4DGxOvWfG5QdcGyE9398MWxui/QUw0swPbQGkjIfywsLzkyic2ELCfhz7KdWY86D 2/Ym/f6XiQrv92ORdOW8rbNCD0xpCkm7djMIEVTvYmMv1QQroK/09xefEPKxnL7Val5s ZPOxTwD/C+xJ8Qp40kfEpeb8jpdSg/qWjMi9T2IeAbvB4wjyeuJY1AjIMLXShXXSdkq6 gwCMFiBSEgvzyfYzxRYcV8q5h5LMB8zmBCYCGjFZ5o/c5HBjfLW0XizlsmhrwuEmPPPq A/G1jLpPHxYsx6qWCYGBd4uviiz7V1QmC8k1D7EtesVQkRFC9VJMSZx3nIXYAN/myus/ bdQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b="1nBhJdv/"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=XOmGFEpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gc22si3905520ejc.97.2021.08.19.07.02.16; Thu, 19 Aug 2021 07:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b="1nBhJdv/"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=XOmGFEpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240416AbhHSOAT (ORCPT + 99 others); Thu, 19 Aug 2021 10:00:19 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:51723 "EHLO wnew3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240412AbhHSOAS (ORCPT ); Thu, 19 Aug 2021 10:00:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 1D8EC2B005D0; Thu, 19 Aug 2021 09:59:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 19 Aug 2021 09:59:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=vrgR/7Ax9Jv2e zbaP/CKQhrK7xJEFBCM3d5iboIQxZw=; b=1nBhJdv/dY7RiDWTlJNKV2EN7m3Gn 6yztKWzx0gxtKbs1HBFOWRzs8yivv0DP+oy7O068uVlZdDwmaQ52pV/RPbMukY5R 3Z4OeQW3MEFejpIMLK9jgDJEUmXTW4P5i+WYmGkn8pQidw2k/R33AqZmPsDWu49W 5Gg/6QmLRsRLH63iR+ZFyJXqh4ZOYNVy4OFJhhk53bkaSye+j+btm0+E9mru0t+P /J0atD3v/MKHqApT7dTab8AxPpPFOWlyvER+aCruYPkJdN+DQySpHdIX4X7wa82L I0vn6AJuMHqqK+wglPCXGPBgKpu6U4F3oviKlw3ZLfekjE38aGuZoQKtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=vrgR/7Ax9Jv2ezbaP/CKQhrK7xJEFBCM3d5iboIQxZw=; b=XOmGFEpb dPHs+Q0cR4vhR90CLTyB+zab0Uand8Tc5F+GgjHw/mHglX614bRHkuDMhe/ZkYxd nz36IimAB47RmiEwZ8kFOmc0I4KtIaqGUkLLiyPBRdlusAHCtCCovWHVta1JUxT+ o1dv1pYcW7BBQ6/yrTNBRnBURn9cBvCnvnDbpNl9S6HAoxcOyuHrGAuT4iHs4oFl 0nq+630ssu24PpOyfcI6YyxbQICXs0eKEE2VIUQoP3Mg0yc6Rr7WDFOsFfUdGvMw RTcQxvOpYPowP1IcDo4CPMzPA4Av7Etau2WTCRrW0cXV1WcnSINuaRPawX8ZmDUi egHcS6AgjDmQXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleejgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Aug 2021 09:59:40 -0400 (EDT) From: Maxime Ripard To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Cc: linux-kernel@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , Boris Brezillon , linux-rpi-kernel@lists.infradead.org, Hans Verkuil , bcm-kernel-feedback-list@broadcom.com, Emma Anholt , Nicolas Saenz Julienne , Maxime Ripard Subject: [PATCH v3 1/6] drm/vc4: select PM Date: Thu, 19 Aug 2021 15:59:26 +0200 Message-Id: <20210819135931.895976-2-maxime@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210819135931.895976-1-maxime@cerno.tech> References: <20210819135931.895976-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already depend on runtime PM to get the power domains and clocks for most of the devices supported by the vc4 driver, so let's just select it to make sure it's there, and remove the ifdef. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/Kconfig | 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig index 118e8a426b1a..f774ab340863 100644 --- a/drivers/gpu/drm/vc4/Kconfig +++ b/drivers/gpu/drm/vc4/Kconfig @@ -9,6 +9,7 @@ config DRM_VC4 select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER select DRM_PANEL_BRIDGE + select PM select SND_PCM select SND_PCM_ELD select SND_SOC_GENERIC_DMAENGINE_PCM diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index c2876731ee2d..602203b2d8e1 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -2107,7 +2107,6 @@ static int vc5_hdmi_init_resources(struct vc4_hdmi *vc4_hdmi) return 0; } -#ifdef CONFIG_PM static int vc4_hdmi_runtime_suspend(struct device *dev) { struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev); @@ -2128,7 +2127,6 @@ static int vc4_hdmi_runtime_resume(struct device *dev) return 0; } -#endif static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) { -- 2.31.1