Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp604473pxb; Thu, 19 Aug 2021 07:08:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgYSvb5J7jN3z4X2MzZaxvk56fBMP6xOg6OTeWX11RTPd/h4/XxyiX6PNgvY8djSsVNN9U X-Received: by 2002:a17:906:4f97:: with SMTP id o23mr16089103eju.418.1629382127293; Thu, 19 Aug 2021 07:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629382127; cv=none; d=google.com; s=arc-20160816; b=F07Z6MzBGgEIdfuqDN9I2qi3FNf/Sd1dmdToj42Iwqab9nA6AIwUNJsyAIyB4XaXAX I9W/+fsLC7TkOOyuH1WBD9AfyHxa2ve4S+3TzAvrlKZO79cQK+bJSDoQuA5TKuryzsJi gZnnrwBolwCUb0GMEjuKO03PGY3P+2grGXFFijpxz8T2h71J47qo/c/leWBShOz7dNg4 zDsCnue8vIjJr7pLR8HMpMdb9CcRGtV5LVZC6AfJJ/tI6tmGokF8aJnEvE3guqCK8sm6 dZqV/1pfPGc1vUopCq/0OrMVnJf4JkaNIZFot9pYZoUnT+Zd2uf9k00vn4uFYrQGrwEo U9mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=A6L874h75lqt6iCXQT/QrZMkN1DPxF2MxZf4dmgaGF0=; b=E9iF7xi5Am0h91e5aucjNdHEL7w01BDa316VPhiQgja22zGmJKg2kUJimbFxcru+1B ZVC6ZmUaTVqs18v4HkBK6EMZ3XP/0z01VSNknAu+PbxiLVpMEBUokjfb7h0X07pK5kdk xDxy5RJ0RH6PKHEzF06jjUFiRTM2r1EL77CPnrpOT9obhlramLhbEt5j5R9r/sYEp6IY ugriNhoPTGj0VqKVmPYneTmr3M5FRvEzXl8hbiF2cuGji5A4fkmmB0Tl4X+k+Dfyn7/H 2QwDmi9h23uOpfFZMFSOShY9hJr7RyxE8aS6zvw/6lpZupndrN4IMQIksmhnykleYpP7 E1PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=TnW5Ck5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si3234104edw.80.2021.08.19.07.08.09; Thu, 19 Aug 2021 07:08:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=TnW5Ck5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240376AbhHSOGO (ORCPT + 99 others); Thu, 19 Aug 2021 10:06:14 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:13831 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240394AbhHSOGN (ORCPT ); Thu, 19 Aug 2021 10:06:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1629381937; x=1660917937; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=wwEbJAwsBPQfHi0nLc5Ius6bVVJXjXqU+Q2IzZhXtsQ=; b=TnW5Ck5ZzQiwTsWnmLPgaEQ78HlHO5S1w2jSJMuwxuH1DjteanZCSQRP R1kGtYZyB2UAoFxyYcKM4ONEtNFIuA3al1jXDZyFas/5Btw8CXfJWhnNE Msi2R77W4lKWzTfQU92o1mvSsai05qP9PmYxEKywCF26/s7n4OaFzHj81 I=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 19 Aug 2021 07:05:37 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 07:05:36 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Thu, 19 Aug 2021 07:05:36 -0700 Received: from [10.226.59.216] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.858.15; Thu, 19 Aug 2021 07:05:35 -0700 Subject: Re: [PATCH v1 2/2] bus: mhi: core: Optimize and update MMIO register write method To: Hemant Kumar , Bhaumik Bhatt , CC: , , References: <1629330634-36465-1-git-send-email-bbhatt@codeaurora.org> <1629330634-36465-3-git-send-email-bbhatt@codeaurora.org> <62646f45-6b31-af0d-4b3c-cc4b5c355a92@codeaurora.org> From: Jeffrey Hugo Message-ID: <995a9d93-8338-45d5-6ff6-a5662795aa9b@quicinc.com> Date: Thu, 19 Aug 2021 08:05:35 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <62646f45-6b31-af0d-4b3c-cc4b5c355a92@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanexm03h.na.qualcomm.com (10.85.0.50) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/2021 7:41 PM, Hemant Kumar wrote: > > > On 8/18/2021 4:50 PM, Bhaumik Bhatt wrote: >> As of now, MMIO writes done after ready state transition use the >> mhi_write_reg_field() API even though the whole register is being >> written in most cases. Optimize this process by using mhi_write_reg() >> API instead for those writes and use the mhi_write_reg_field() >> API for MHI config registers only. >> >> Signed-off-by: Bhaumik Bhatt > Reviewed-by: Hemant Kumar > Reviewed-by: Jeffrey Hugo