Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759217AbWLDD56 (ORCPT ); Sun, 3 Dec 2006 22:57:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759229AbWLDD56 (ORCPT ); Sun, 3 Dec 2006 22:57:58 -0500 Received: from mailout1.vmware.com ([65.113.40.130]:9640 "EHLO mailout1.vmware.com") by vger.kernel.org with ESMTP id S1759217AbWLDD55 convert rfc822-to-8bit (ORCPT ); Sun, 3 Dec 2006 22:57:57 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff Date: Sun, 3 Dec 2006 19:53:48 -0800 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff Thread-Index: AccXT4dShjHaXeUoR2aPPgHcLx3mrwACEZCn References: <20061202043746.GE30531@localdomain><20061203132618.d7d58f59.akpm@osdl.org> <45738959.1000209@acm.org> <20061203185442.33faf1c0.randy.dunlap@oracle.com> From: "Bela Lubkin" To: "Randy Dunlap" , "Andrew Morton" Cc: "Corey Minyard" , "OpenIPMI Developers" , "Linux Kernel" , "Joseph Barnett" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 24 Andrew Morton wrote: > > Sometime, please go through the IPMI code looking for all these > > statically-allocated things which are initialised to 0 or NULL and remove > > all those intialisations? They're unneeded, they increase the vmlinux > > image size and there are quite a number of them. Thanks. Randy Dunlop replied: > I was just about to send that patch. Here it is, > on top of the series-of-12. ... > -static int bt_debug = BT_DEBUG_OFF; > +static int bt_debug; Is it wise to significantly degrade code readability to work around a minor compiler / linker bug? >Bela< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/