Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759282AbWLDEBh (ORCPT ); Sun, 3 Dec 2006 23:01:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759247AbWLDEBh (ORCPT ); Sun, 3 Dec 2006 23:01:37 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:51359 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S1759282AbWLDEBg (ORCPT ); Sun, 3 Dec 2006 23:01:36 -0500 Message-ID: <45739DB4.6000806@oracle.com> Date: Sun, 03 Dec 2006 20:01:56 -0800 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Bela Lubkin CC: Andrew Morton , Corey Minyard , OpenIPMI Developers , Linux Kernel , Joseph Barnett Subject: Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff References: <20061202043746.GE30531@localdomain><20061203132618.d7d58f59.akpm@osdl.org> <45738959.1000209@acm.org> <20061203185442.33faf1c0.randy.dunlap@oracle.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 35 Bela Lubkin wrote: > Andrew Morton wrote: > >>> Sometime, please go through the IPMI code looking for all these >>> statically-allocated things which are initialised to 0 or NULL and remove >>> all those intialisations? They're unneeded, they increase the vmlinux >>> image size and there are quite a number of them. Thanks. > > Randy Dunlop replied: > >> I was just about to send that patch. Here it is, >> on top of the series-of-12. > ... >> -static int bt_debug = BT_DEBUG_OFF; >> +static int bt_debug; > > Is it wise to significantly degrade code readability to work around a minor > compiler / linker bug? Is that the only one that is a problem? I don't think it's a problem. We *know* that static data areas are init to 0. Everything depends on that. If that didn't work it would all break. I could say that it's a nice coincidence that BT_DEBUG_OFF == 0, but I think that it's more than coincidence. -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/