Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YRukaQbrgDWhiwGr@localhost.localdomain>
In-Reply-To: <YRukaQbrgDWhiwGr@localhost.localdomain>
From:   Namhyung Kim <namhyung@gmail.com>
Date:   Thu, 19 Aug 2021 09:28:13 -0700
Message-ID: <CAM9d7chOtKDTmiZz7EUDX76BMWRzWJATmJZLcTiLeu5k_qRg0g@mail.gmail.com>
Subject: Re: [PATCH] perf, android: fixup get_current_dir_name() compilation
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello,

On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> strdup() prototype doesn't live in stdlib.h .
>
> Add limits.h for PATH_MAX definition as well.
>
> Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>
>  tools/perf/util/get_current_dir_name.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -3,8 +3,9 @@
>  //
>  #ifndef HAVE_GET_CURRENT_DIR_NAME
>  #include "get_current_dir_name.h"
> +#include <limits.h>
> +#include <string.h>
>  #include <unistd.h>
> -#include <stdlib.h>
>
>  /* Android's 'bionic' library, for one, doesn't have this */
>