Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 0/3] SVM 5-level page table support
To:     Wei Huang <wei.huang2@amd.com>, kvm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, vkuznets@redhat.com,
        seanjc@google.com, wanpengli@tencent.com, jmattson@google.com,
        joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, x86@kernel.org, hpa@zytor.com
References: <20210818165549.3771014-1-wei.huang2@amd.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <46a54a13-b934-263a-9539-6c922ceb70d3@redhat.com>
Date:   Thu, 19 Aug 2021 18:43:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210818165549.3771014-1-wei.huang2@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/08/21 18:55, Wei Huang wrote:
> This patch set adds 5-level page table support for AMD SVM. When the
> 5-level page table is enabled on host OS, the nested page table for guest
> VMs will use the same format as host OS (i.e. 5-level NPT). These patches
> were tested with various combination of different settings and test cases
> (nested/regular VMs, AMD64/i686 kernels, kvm-unit-tests, etc.)
> 
> v2->v3:
>   * Change the way of building root_hpa by following the existing flow (Sean)
> 
> v1->v2:
>   * Remove v1's arch-specific get_tdp_level() and add a new parameter,
>     tdp_forced_root_level, to allow forced TDP level (Sean)
>   * Add additional comment on tdp_root table chaining trick and change the
>     PML root table allocation code (Sean)
>   * Revise Patch 1's commit msg (Sean and Jim)
> 
> Thanks,
> -Wei
> 
> Wei Huang (3):
>    KVM: x86: Allow CPU to force vendor-specific TDP level
>    KVM: x86: Handle the case of 5-level shadow page table
>    KVM: SVM: Add 5-level page table support for SVM
> 
>   arch/x86/include/asm/kvm_host.h |  6 ++--
>   arch/x86/kvm/mmu/mmu.c          | 56 ++++++++++++++++++++++-----------
>   arch/x86/kvm/svm/svm.c          | 13 ++++----
>   arch/x86/kvm/vmx/vmx.c          |  3 +-
>   4 files changed, 49 insertions(+), 29 deletions(-)
> 

Queued, thanks, with NULL initializations according to Tom's review.

Paolo