Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <m31r7lcpyz.fsf@t19.piap.pl>
In-Reply-To: <m31r7lcpyz.fsf@t19.piap.pl>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Thu, 19 Aug 2021 09:48:10 -0700
Message-ID: <CAJ+vNU35OoSs+AcV0xFmae1CPn9T+3tbs29YxmXC17WgO+vSXQ@mail.gmail.com>
Subject: Re: [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value
To:     =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 26, 2021 at 3:46 AM Krzysztof Ha=C5=82asa <khalasa@piap.pl> wro=
te:
>
> Signed-off-by: Krzysztof Ha=C5=82asa <khalasa@piap.pl>
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 043cc8275d00..cbfe58e413e9 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_=
subdev *sd,
>                                      struct v4l2_dv_timings *timings)
>  {
>         struct tda1997x_state *state =3D to_state(sd);
> +       int ret;
>
>         v4l_dbg(1, debug, state->client, "%s\n", __func__);
>         memset(timings, 0, sizeof(struct v4l2_dv_timings));
>         mutex_lock(&state->lock);
> -       tda1997x_detect_std(state, timings);
> +       ret =3D tda1997x_detect_std(state, timings);
>         mutex_unlock(&state->lock);
>
> -       return 0;
> +       return ret;
>  }
>
>  static const struct v4l2_subdev_video_ops tda1997x_video_ops =3D {

Krzysztof,

Patch looks good to me but needs a commit log.

Best regards,

Tim