Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp752040pxb; Thu, 19 Aug 2021 10:19:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlCipCYmEF2+DsPBmrGOy3h87P1sX7xbfCdFCC/AM4enrixDm0CJJejUAn6QOUSimyQuBl X-Received: by 2002:a05:6402:148c:: with SMTP id e12mr16997990edv.239.1629393559813; Thu, 19 Aug 2021 10:19:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629393559; cv=none; d=google.com; s=arc-20160816; b=JXxfmtvBLXv3cWB6AQUo/27LRQrPEBZc7Xu1qy03s45kxJdrhzzqrv90out2qhx9QP 4jYszFQmOKT8btHnsdn2MEuDPElf1AGiRjSe/sZItvnW1b59e+myxeklrWhRYKm30Rdd FqUHDP5to3id3sZtCnQRHrdj2NSGBZcfR0YfaE1Hsk16p+YgTuP0oWEmc55HRZpvgLke pXpypnbyao1Uqba4aPnSBr7N/Vj+nZ0KIdrNx1DlNsfLLKO2z6spRM2e0vOPmV2Oi471 7LNDZzF8n1xprjXDN+EyqBTKx9DKQUh8UqdWJXQ7MFJ1mYwIy5SpOfbp2TE48tztOqq0 m7GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=9OrzBDI9aonJAy5nn5cFhKWv9b0xLY+sStEgxrDvSeg=; b=hZ7ltJsiphK8aNrjxz7gOWbLXe4cN+aQb2KR5BszjW/MBTH4gbpmr/Xl7AC1V8T9XC KYVZL96C3fS3GFTCFUFBHvMh67AdWWl2f8MkGE3YQPx7ibsWxj+n/da7jMUhEkoOWcgT z4nrx4PjcJuWtD2GtKFWHzMdKULZzdGM3QlCzK1i1Q7hNy1BB3OA0KAQiWiDmIzt8iBY TwMGi4qMCVwJqVk+kyuqAVn+5ZHPgnl77do2pez4soDplydfG7Hu0g/nbCsokfOkko6R OZzLhtn9v4HRYB0++hDwNZ8batAbqTBanM3AO+zskR6+LygdyC9/dNA2bMMGD/3rwqXz 0MWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=NTlkBnit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lm21si3862528ejb.20.2021.08.19.10.18.47; Thu, 19 Aug 2021 10:19:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=NTlkBnit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbhHSRRZ (ORCPT + 99 others); Thu, 19 Aug 2021 13:17:25 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:33554 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbhHSRRT (ORCPT ); Thu, 19 Aug 2021 13:17:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629393403; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=9OrzBDI9aonJAy5nn5cFhKWv9b0xLY+sStEgxrDvSeg=; b=NTlkBnitX2bFPsV89HNyJstCvc09Yy0k17P718fPzRhECKCJ7PWxTwDMUmMcElBKNalCqvlI /XayBr3UFR7+h3qQepHDE5ugxfeIyp09aP1S6vLNerP0RXipaaA9DOVkpV1k7YtcwPSFbGrN d+BUFqwzsmBeoTBFOFPQnqAGN94= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 611e91d466ff1079045f1840 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 19 Aug 2021 17:16:04 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A7BADC4338F; Thu, 19 Aug 2021 17:16:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from malabar-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id C431CC4338F; Thu, 19 Aug 2021 17:16:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org C431CC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Bhaumik Bhatt To: manivannan.sadhasivam@linaro.org Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, quic_jhugo@quicinc.com, Bhaumik Bhatt Subject: [PATCH v2 0/2] MHI MMIO register write updates Date: Thu, 19 Aug 2021 10:15:52 -0700 Message-Id: <1629393354-20769-1-git-send-email-bbhatt@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of MHI MMIO writes, the register field write function needs to do reads before writes are performed. Propagate read failures such that callers are made aware of those and can take appropriate action instead of running blind. Optimizing the MMIO initialization function to use mhi_write_reg() in most cases should also be done to improve design. These patches were tested on X86_64 architecture with Ubuntu 18.04 and SDX65 attach. v2: -Fix testbot reported missing set of changes from pm.c Bhaumik Bhatt (2): bus: mhi: core: Bail on writing register fields if read fails bus: mhi: core: Optimize and update MMIO register write method drivers/bus/mhi/core/boot.c | 25 ++++++++++----- drivers/bus/mhi/core/init.c | 70 +++++++++++++++++++++++------------------ drivers/bus/mhi/core/internal.h | 7 +++-- drivers/bus/mhi/core/main.c | 9 ++++-- drivers/bus/mhi/core/pm.c | 18 ++++++++--- 5 files changed, 80 insertions(+), 49 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project