Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
CC:     "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Rob Herring <robh+dt@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH devicetree 2/2] MIPS: mscc: ocelot: mark the phy-mode for
 internal PHY ports
Thread-Topic: [PATCH devicetree 2/2] MIPS: mscc: ocelot: mark the phy-mode for
 internal PHY ports
Thread-Index: AQHXlRxE6gwTVobZAUmt38ortI/KCKt7EdYA
Date:   Thu, 19 Aug 2021 17:17:05 +0000
Message-ID: <20210819171704.z3avr2b5jur6dohl@skbuf>
References: <20210819170416.2252210-1-vladimir.oltean@nxp.com>
 <20210819170416.2252210-2-vladimir.oltean@nxp.com>
In-Reply-To: <20210819170416.2252210-2-vladimir.oltean@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YAGqc1dPRny5fQ6Plv+AdWE4snfF3o+BJHFXUW1JV35nERLMOHSeZ7Omjwe8?=
 =?us-ascii?Q?yGgscU53QGg7GxuRuKBRmdgUAlt1XXZ6dZh82NtPE/7KeCThFU9u8SxuD692?=
 =?us-ascii?Q?tnSvZdr9T5JIld+AtiuEaBMYRCslftGDk6WpujkBR6yWti8eU7yeULWnPKon?=
 =?us-ascii?Q?cIgh91xt91ZrcfsMhSVJ4qdR82CXYoaG5E/Dw3aT59Oc86lZMAqy23egwtS6?=
 =?us-ascii?Q?xZV0O7UG21gZWa7ewwgZIoLSv6ICfqJll5/flqXGCU6dwXvvoXHpw3l/weDx?=
 =?us-ascii?Q?1kU1MOo2q+nvJZQEquuxtnpYDHar3nSOPHQmSTNPCGS1R5TBO/POZVsRfth1?=
 =?us-ascii?Q?gpqXf3WEz6JaAlVzsiXkWXmE3n4t3dznslzxJxuJBz6iUJSW/8GjmpkthfXf?=
 =?us-ascii?Q?VIpq3X0+W0WrdK4YVRaM8bvIPeYAA3RlsA3n1nZn9yqh+bZ710UZ3zw6NA0D?=
 =?us-ascii?Q?KlciHawCObmYZuS5CUnr6i9zPz/3/SijK8S9w0pkkDeksLEi00mEep/h2Cz4?=
 =?us-ascii?Q?fi+Y2aqlbP0ArTPnsKuwhNLrzDyIlNk/RHem2UYuzGlGLITpu73jFsUs/k+T?=
 =?us-ascii?Q?uxue1ff1kuLzwtdf6teQ55WFOpWfV+kYXpwQiCxSHKiaMb2fMZUCrgvGpJMn?=
 =?us-ascii?Q?SprxKB5UciDCi+P3AM5QNlSiVyfCFErTdIlV+O9489eza9Qf4SEj5diGDKMz?=
 =?us-ascii?Q?w2/bWdRxTlqDqEokILi/qr2961fgpVMLndQbked/UuQjsbb5N0LevJyeliIF?=
 =?us-ascii?Q?8x7iu0Rrwz0CuKqSoeN5NZgk8mDaEYAYOZh/Fe6qiQByt8YppkL47kvIFiAN?=
 =?us-ascii?Q?Rt/HJVdZROOmK9mR3nInWWXajgrwsde9cZ0dJrQ6U02LMM/acZ71GTg3l0F3?=
 =?us-ascii?Q?ARgNpakXI4zjC8ucQmRWCHq+gN4hbhalROxKgPF9mjyu/H1vCsqFMTnAF2g/?=
 =?us-ascii?Q?G13GzQTRtAhMbXb9q8DKVu7lcm/eM+svFsuBioEHsutqY0usec0pYh4QU+hZ?=
 =?us-ascii?Q?srtw5FSBGdKCwc4W8z3GeOeDW2lrT0hbuuNz/V6tXkvwkGxsKoBm2ubuks3v?=
 =?us-ascii?Q?TtdIVlnHTx05egZjceJg7tae4D5VUWaCsndNkwQ/5LBPsXh1chDTOgT4MJuc?=
 =?us-ascii?Q?9BoJ0621kMFVD/hmGMc1lvw4mOdqT+N/H5T0OLbuekgbD2U9QyzR+lBw1x4i?=
 =?us-ascii?Q?i4De/8te8hoULM/WJHln3OECkg+Ksp4LDSY6JLCq8+uyT0hanUkxRBT81z2b?=
 =?us-ascii?Q?mxoKGN8xKQOZoSfEcoPkcum+aaNWrFTSQrZTLz8E/FQ+PJQEVpTlt0YtWbNO?=
 =?us-ascii?Q?Iqh61Io043ZzJEnM0rGgLfhY?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E8C1A8DC4A85B84A87A525BDF60329EC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d81472de-0f92-4fae-506e-08d963352ac5
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2021 17:17:05.0956
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JWqEnqxlYKLMyQ628cdKVGp0Z00YGryCVcLH/c6LgANbFSQZBKkuvxARH4zN5M2Sm4p3fWCXNce4fYEL+pV7eQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3712
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 19, 2021 at 08:04:16PM +0300, Vladimir Oltean wrote:
> The ocelot driver was converted to phylink, and that expects a valid
> phy_interface_t. Without a phy-mode, of_get_phy_mode returns
> PHY_INTERFACE_MODE_NA, which is not ideal because phylink rejects that.
>=20
> The ocelot driver was patched to treat PHY_INTERFACE_MODE_NA as
> PHY_INTERFACE_MODE_INTERNAL to work with the broken DT blobs, but we
> should fix the device trees and specify the phy-mode too.
>=20
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

Please note that the pre-phylink driver has this check:

		switch (ocelot_port->phy_mode) {
		case PHY_INTERFACE_MODE_NA:
			(...)
		case PHY_INTERFACE_MODE_SGMII:
			(...)
		case PHY_INTERFACE_MODE_QSGMII:
			(...)
		default:
			dev_err(ocelot->dev,
				"invalid phy mode for port%d, (Q)SGMII only\n",
				port);
			of_node_put(portnp);
			err =3D -EINVAL;
			goto out_teardown;
		}

So it does not actually expect PHY_INTERFACE_MODE_INTERNAL and will
error out.

Are we okay with the new device tree blobs breaking the old kernel?

Should we instead wait for a few more kernel release cycles before
changing the device tree in this regard?=