Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp757654pxb; Thu, 19 Aug 2021 10:26:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4rNL7+l+6ajuFQvlrS2agbezm0UCQlC/BCj/aR7ylvQXiGe7ZBOvP/ras+V5cPpyvdzL2 X-Received: by 2002:a05:6402:288b:: with SMTP id eg11mr17621660edb.241.1629394018799; Thu, 19 Aug 2021 10:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629394018; cv=none; d=google.com; s=arc-20160816; b=EvwaGqY0O3Gpm852PLnDtCiaMULMpLs4KsV1gGB5+3WoIK+/PyRwvY01Lbogb2HPXS oNGvkYGjmz4qNShkYWI96c51DogOibTVRbmVL71PZ6ruclx13RC/Z+Ii5U7RbNMwwRxf oxk22MvL1wog3PV/Natj5oIkeIJk5iDxgnlPhX6/Li/CCvuqVeIm6nK/J+jdVNol4hVc VxNK2Ic5TL/dw4NXS8plbBHlpuyZVmLV9LgO99nHcQhJlOQCuNum4IxOgcaBFQwtmF2J Wkx7t4E+EMPq8nqltm+XW3EGdJHCsUf/+oMRPPctFQq5lA39gk92X9zYqKB6vWQaIEjc BRag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=egaoZwC4rZ4/dIah6if50WUKCEkDpfq88EIvJ7O/wVQ=; b=bBg8RYsE1TiEabuqhh5wzJUhCpBhBzddszfsSkIO0WYg6nyD+zWO3GqdKBz3rPbmrL UkXrrKikEBZf61nrPIaZRtyZwfKXYV+s4uEj1mEghz+7XqCniwM+ic4WVS8A3HzCl0MA 4Qujeux6aS5ytopYfOeeE83hOihB2V5fD2N69dNdx4Z88s08QIbFv5EI7RgYd6lrXqZG 9E946tg/p0AvonimMQjcYTIbv5hVy5YHAlYxN5+tXu4rvtTVKo0T6xtBziwVOdA2Lztg FN57jAsNIRF+W1hH8ZzTsysJOiqj1g4x0dt/giUae8vpQzC22CoZjUMpwO8WfthNvULX rjrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TI2jtzCr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si3874727ejx.333.2021.08.19.10.26.35; Thu, 19 Aug 2021 10:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TI2jtzCr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbhHSRWO (ORCPT + 99 others); Thu, 19 Aug 2021 13:22:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230416AbhHSRWO (ORCPT ); Thu, 19 Aug 2021 13:22:14 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC551C061575; Thu, 19 Aug 2021 10:21:37 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id m26so6126667pff.3; Thu, 19 Aug 2021 10:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=egaoZwC4rZ4/dIah6if50WUKCEkDpfq88EIvJ7O/wVQ=; b=TI2jtzCrSXvEeb21lI4jkNgetmIdroz8sDWZm8yrT2dk0MWKikhsPwuwx6r5dnKird p+fuTjZiq6caheadW6ugPBt1rKWBiI2dTzQYM61tVqEtTLwVLnIxgnptnS7OBlDi3XS7 SE0Oz5IkAan4WQahRNDVLvJr2p/6Mz3Q/C2+R4UkeHie7K9nBmdvaRH9uaXyhtG1UR4U a0cOUtyRoYHahHnESguDOUA24XBdxxIaPbFfDoN2uur1htIgXnCbXZ1gsrQPABaa8PCr TSOll4M3fxc+zHq+DNKtJSDVZw/0NlDSunHe+0/vs5CaEvJHhjWZxPU35EBXaPolcOH0 Cc9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=egaoZwC4rZ4/dIah6if50WUKCEkDpfq88EIvJ7O/wVQ=; b=rnyOaznuFFVZPshT7GmlbIXa3hjkqC8RqkhEwWSp4MvNnD9SDhfMXUxLC0NEnhBIxV A3NWs/6FFHi/BNXqkEPVQdYEvWXtQ1Hx95DF5v27EvmtwM47zl1yEX7n6aD2Tdmzxj8S lgkGb7piEN1VXzZcZEvl2AfAZMvDe/y7rFE9unAT7IFNLRLPJmodxmXQLDUJyFoFiokZ BPN0FFUItm9q5AOjijCrZ6mbqgeIcdHYsfrcsdroAG5Z1A1YBSHZL8MyKBAVvCmAoGYq RSY5CWJt49Y6x3Dx6+PZyzyo0cIBcz3KQsgARA3cdaoPO6i4tP82UpnEEPFLxh32fNSW eY3Q== X-Gm-Message-State: AOAM5326ucA4r4NvVGl5ZV+LFd/G3DLB8oMZIRKyDKvbGM//Ryw9EaZg R+WFdWEz2Y/X+ro6MhRwQmJPQCgHhXoW8rOxYWA= X-Received: by 2002:a63:cf0a:: with SMTP id j10mr15038622pgg.4.1629393697365; Thu, 19 Aug 2021 10:21:37 -0700 (PDT) MIME-Version: 1.0 References: <20210819132416.175644-1-yangyingliang@huawei.com> In-Reply-To: <20210819132416.175644-1-yangyingliang@huawei.com> From: Andy Shevchenko Date: Thu, 19 Aug 2021 20:20:58 +0300 Message-ID: Subject: Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume() To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, jic23@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang wrote: > > Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume(). ... > ret = clk_prepare_enable(adc->adclk); > - if (ret) > + if (ret) { > + clk_disable_unprepare(adc->pclk); > return ret; > + } Huh?! -- With Best Regards, Andy Shevchenko