Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <m3wnpdbb9h.fsf@t19.piap.pl>
In-Reply-To: <m3wnpdbb9h.fsf@t19.piap.pl>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Thu, 19 Aug 2021 12:47:23 -0700
Message-ID: <CAJ+vNU2r0SgJODHpqDmKzaQkRVXn+SJugoZ45aG0+U-Tbpm5Sw@mail.gmail.com>
Subject: Re: [PATCH] TDA1997x: report -ENOLINK after disconnecting HDMI source
To:     =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 26, 2021 at 3:49 AM Krzysztof Ha=C5=82asa <khalasa@piap.pl> wro=
te:
>
> The TD1997x chip retains vper, hper and hsper register values when the
> HDMI source is disconnected. Use a different means of checking if the
> link is still valid.
>
> Signed-off-by: Krzysztof Ha=C5=82asa <khalasa@piap.pl>
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 0b516a45a135..36a7b89afb08 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -1107,7 +1107,8 @@ tda1997x_detect_std(struct tda1997x_state *state,
>         hper =3D io_read16(sd, REG_H_PER) & MASK_HPER;
>         hsper =3D io_read16(sd, REG_HS_WIDTH) & MASK_HSWIDTH;
>         v4l2_dbg(1, debug, sd, "Signal Timings: %u/%u/%u\n", vper, hper, =
hsper);
> -       if (!vper || !hper || !hsper)
> +
> +       if (!state->input_detect[0] && !state->input_detect[1])
>                 return -ENOLINK;
>
>         for (i =3D 0; v4l2_dv_timings_presets[i].bt.width; i++) {

Acked-By: Tim Harvey <tharvey@gateworks.com>

Best regards,

Tim