Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp862155pxb; Thu, 19 Aug 2021 13:11:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJghbxkMLbvUjSQEkPu7QmCvfAdeg+Iar69bb308UP4xaAarKx7kWd6OVC5FRiQivQFcbG X-Received: by 2002:a17:906:1cc9:: with SMTP id i9mr17823577ejh.345.1629403913265; Thu, 19 Aug 2021 13:11:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629403913; cv=none; d=google.com; s=arc-20160816; b=BTBWhCdrGH6tLzipX7ZEaJtW4JvG0XBpaQC0WBSZXYefgewGqhU5wttB+C47TL8kN1 sLqsCET0jzS632z8iIi8d03VASWKX53DQQhduyfx1JoMvo8cDAoCwiT1I4gYuvYDkPYi VuzYAPNmUTV4h85Wr9gdr0loiadpWzu4GxV0ZIAGQ1mOistDJuhKyiJKhocku0QBZ4nS /ud9Iw3gVXwvo05SlSnFMwdduBHB9KNKa6PhZOKYOY8PKJs7QEoG4ZqJZalXpX4cwyad BNjl4JFYMa4LBfVrZclva9tI/KxNYkR0SxHfUm2tQxnKsXmn9gNNtVFGM7+CcagBVbFm PU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hEHyflATa8ZJ9MWfAJnBQNhj3JsC3JBcJ/6ag3O0bBs=; b=C0PSCoNbiV5nUeLzdrzMBlXVwePRuTeekyAgaJeu3KkFPPVzM3DVZfyksplyYkue2l oTf/PPt2Po/LxbXtjXeLAoQ7C+5mVHrrjXCQfkpePTANo4X4sdi8YX2i0tFk1ExuIvtf 3tyCRqE5dckDd2UBWKsSaAFYGiQSwY8MNqkLZ3tow9An4AstyozUZwDjelD/9NqGSBCy bAtKdSGWLOmxuL9/sunQrP7CAIhk2Xfaq8sgjv8TecawhUvH/qJTIMZQ9RTj9t9HwZJc GALtdxsq/uSHJUSokdriu2TqAaiQC81an8kTQj+8Mo1a7MPbthcDr26zRmVb2H0tv7Xx UXDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=TZhIXS2N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p18si4243331ejb.559.2021.08.19.13.11.27; Thu, 19 Aug 2021 13:11:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=TZhIXS2N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhHSUK1 (ORCPT + 99 others); Thu, 19 Aug 2021 16:10:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbhHSUK1 (ORCPT ); Thu, 19 Aug 2021 16:10:27 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8883BC061575 for ; Thu, 19 Aug 2021 13:09:50 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id w17so14475734ybl.11 for ; Thu, 19 Aug 2021 13:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hEHyflATa8ZJ9MWfAJnBQNhj3JsC3JBcJ/6ag3O0bBs=; b=TZhIXS2Nkzr4Lx+5LUIlp18eYdMQ7B0cjj8Z0IbEZ/ObpK6HI3T8NOujHdCs0PcSOa OGE3Komvk0XoGwMQ6mQbA972igMURrCNEebMzS3qw2irQ2osaRdSSunn7/vzyBqrAI77 IIri+i7ziX5jVotImaZ8iaMqR1/hSP+ToXytirSjCJ8TjQ2cKM5ekG7v3oyRuiKHoHvp ZBLdGsec7YdoL/7bzXY5JUiJMO7+k0jd08tPHrNoqCoLf62+AlykjKvxLyuV34fk3FJU 3HVg8nxdBmKopszRY+bGAjBOprKXwp2CA6ppsyyyccBa1IeNlAqvSw1vG46Du1YlT9eV ruIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hEHyflATa8ZJ9MWfAJnBQNhj3JsC3JBcJ/6ag3O0bBs=; b=cS3st57IOxdjBy0cPgl84QCtz+H9UULWRszEZmxVSGvWwhfQ5j3MxuXCmrpjeSsqvP BPW9WBU3m+N65JynT/uEioyu+BTasR6+c5VkG42mHwlwibHbNFCwMar5/Tdrrdripwhu DL2F5dxIYg2Dzt+p/GhgFQunvxwuxOJi6e17Ndqe6rZoTSaEdzcg4SSuQotxsaYeIxDh aA2qb/6p3n7aBgWDxhbxf/ItyBO3Qw+q0jyN8wsOHtltyaP3Cd8ALbi9OoMLb1TJqhDg 4UHLMN+QXAMAbaWW2EgiuaOQsmoLQKkADFkViWooqTqBax7imGbXNP//QpLxo8xPX0TP L6uA== X-Gm-Message-State: AOAM53076h8liWoZ3MHRR+e8QaSiHqn9eXPIi2B/w2pqqpIZNgwnSPev pquwrAizNx02b0nlMhpdUP/yF7/GiWWQNHbx9IQNdg== X-Received: by 2002:a25:ab62:: with SMTP id u89mr21409435ybi.93.1629403789500; Thu, 19 Aug 2021 13:09:49 -0700 (PDT) MIME-Version: 1.0 References: <20210819150712.59948-1-songmuchun@bytedance.com> In-Reply-To: <20210819150712.59948-1-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 19 Aug 2021 13:09:38 -0700 Message-ID: Subject: Re: [PATCH v2] mm: introduce PAGEFLAGS_MASK to replace ((1UL << NR_PAGEFLAGS) - 1) To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , Matthew Wilcox , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 8:07 AM Muchun Song wrote: > > Instead of hard-coding ((1UL << NR_PAGEFLAGS) - 1) everywhere, introducing > PAGEFLAGS_MASK to make the code clear to get the page flags. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt