Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210819154818.18334-1-lutovinova@ispras.ru>
In-Reply-To: <20210819154818.18334-1-lutovinova@ispras.ru>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 19 Aug 2021 17:15:38 -0300
Message-ID: <CAOMZO5DiaNnxc6X77jyPp9PxAUmc2-HdgE0nh4uBda_eLaBimQ@mail.gmail.com>
Subject: Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3
To:     Nadezda Lutovinova <lutovinova@ispras.ru>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        USB list <linux-usb@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        ldv-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nadezda,

On Thu, Aug 19, 2021 at 12:48 PM Nadezda Lutovinova
<lutovinova@ispras.ru> wrote:
>
> If IRQ occurs between calling  devm_request_threaded_irq() and
> initializing dwc3_imx->dwc3, then null pointer dereference occurs
> since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.

"necessary"

> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>

Reviewed-by: Fabio Estevam <festevam@gmail.com>