Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Aug 2021 14:02:33 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     butt3rflyh4ck <butterflyhuangxx@gmail.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        butt3rflyh4ck <butterflyhhuangxx@gmail.com>,
        bjorn.andersson@linaro.org
Subject: Re: [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint_post
Message-ID: <20210819140233.5f8d8cd1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <763a3f4d-9edc-bb0d-539c-c97309a4975d@gmail.com>
References: <20210819181458.623832-1-butterflyhuangxx@gmail.com>
        <20210819121630.1223327f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <3a5aef93-fafb-5076-4133-690928b8644a@gmail.com>
        <CAFcO6XMTiEmAfVJ4rwdeB6QQ7s3B-1hx3LJpa-StCb-WJwasPg@mail.gmail.com>
        <763a3f4d-9edc-bb0d-539c-c97309a4975d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 19 Aug 2021 23:24:39 +0300 Pavel Skripkin wrote:
> On 8/19/21 11:06 PM, butt3rflyh4ck wrote:
> > Yes, this bug can be triggered without your change. The reason why I
> > point to your commit is to make it easier for everyone to understand
> > this bug.
> 
> As I understand, purpose of Fixes: tag is to point to commit where the 
> bug was introduced. I could be wrong, so it's up to maintainer to decide 
> is this Fixes: tag is needed or not :)

You're right thanks for pointing that out. May it should actually be:

Fixes: 0baa99ee353c ("net: qrtr: Allow non-immediate node routing") ?