Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint_post
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     butt3rflyh4ck <butterflyhuangxx@gmail.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        butt3rflyh4ck <butterflyhhuangxx@gmail.com>,
        bjorn.andersson@linaro.org
References: <20210819181458.623832-1-butterflyhuangxx@gmail.com>
 <20210819121630.1223327f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <3a5aef93-fafb-5076-4133-690928b8644a@gmail.com>
 <CAFcO6XMTiEmAfVJ4rwdeB6QQ7s3B-1hx3LJpa-StCb-WJwasPg@mail.gmail.com>
 <763a3f4d-9edc-bb0d-539c-c97309a4975d@gmail.com>
 <20210819140233.5f8d8cd1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
Message-ID: <e24737f1-5793-805a-5979-ec564ab1db13@gmail.com>
Date:   Fri, 20 Aug 2021 00:16:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210819140233.5f8d8cd1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/20/21 12:02 AM, Jakub Kicinski wrote:
> On Thu, 19 Aug 2021 23:24:39 +0300 Pavel Skripkin wrote:
>> On 8/19/21 11:06 PM, butt3rflyh4ck wrote:
>> > Yes, this bug can be triggered without your change. The reason why I
>> > point to your commit is to make it easier for everyone to understand
>> > this bug.
>> 
>> As I understand, purpose of Fixes: tag is to point to commit where the 
>> bug was introduced. I could be wrong, so it's up to maintainer to decide 
>> is this Fixes: tag is needed or not :)
> 
> You're right thanks for pointing that out. May it should actually be:
> 
> Fixes: 0baa99ee353c ("net: qrtr: Allow non-immediate node routing") ?
> 

Yes, this is correct one. I guess, patch author has chosen 194ccc88297a, 
because my commit has same Fixes: tag (wrong one, btw).


With regards,
Pavel Skripkin