Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Aug 2021 16:58:52 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Eryu Guan <eguan@linux.alibaba.com>
Cc:     Eryu Guan <guan@eryu.me>, fstests@vger.kernel.org, hare@suse.de,
        dgilbert@interlog.com, jeyu@kernel.org, lucas.demarchi@intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] common/module: add patient module rmmod support
Message-ID: <YR7wPBGu1Ba/4kzR@bombadil.infradead.org>
References: <20210811154512.1813622-1-mcgrof@kernel.org>
 <20210811154512.1813622-3-mcgrof@kernel.org>
 <YRkIttM75q3gLxpN@desktop>
 <YR0TEE8lUwo6QlHw@bombadil.infradead.org>
 <20210819022644.GP60846@e18g06458.et15sqa>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210819022644.GP60846@e18g06458.et15sqa>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Thu, Aug 19, 2021 at 10:26:44AM +0800, Eryu Guan wrote:
> On Wed, Aug 18, 2021 at 07:02:56AM -0700, Luis Chamberlain wrote:
> > On Sun, Aug 15, 2021 at 08:29:42PM +0800, Eryu Guan wrote:
> > > 
> > > Use "$max_tries -ne 0" to check inters seems better.
> > 
> > max_tries can be "forever", in which case this is -eq 0:
> > 
> > $ foo="forever"; if [[ $foo -eq 0 ]]; then echo buggy; else echo ok; fi
> > buggy
> 
> I see, that makes sense. Then perhaps some comments would help.

I had sent out a v3 before seeing this request. I'll send a v4 with 
a comment clarifying this.

  Luis