Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210422120459.447350175@infradead.org> <20210422123309.039845339@infradead.org>
 <20210817151542.GA1665@asgard.redhat.com> <YRvbS5ypWhcsBzzU@hirez.programming.kicks-ass.net>
 <20210817231734.GA4449@asgard.redhat.com> <YR473ZGeKqMs6kw+@hirez.programming.kicks-ass.net>
In-Reply-To: <YR473ZGeKqMs6kw+@hirez.programming.kicks-ass.net>
From:   Josh Don <joshdon@google.com>
Date:   Thu, 19 Aug 2021 17:18:22 -0700
Message-ID: <CABk29Ns9s5Nr25qVPtOxABchMk1BFqOb1wpEXhQpF8=jpgqAFQ@mail.gmail.com>
Subject: Re: [PATCH] sched: Fix Core-wide rq->lock for uninitialized CPUs
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Eugene Syromiatnikov <esyr@redhat.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "Hyser,Chris" <chris.hyser@oracle.com>,
        Ingo Molnar <mingo@kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Christian Brauner <christian.brauner@ubuntu.com>, ldv@strace.io
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Peter,

On Thu, Aug 19, 2021 at 4:09 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> -       /* shared state */
> +       /* shared state -- careful with sched_core_cpu_deactivate() */

Could also throw these fields into a wrapping struct. Either way seems fine.

Reviewed-by: Josh Don <joshdon@google.com>