Date: Mon, 4 Dec 2006 12:48:51 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>, Matthew Wilcox <matthew@wil.cx>,
       Linus Torvalds <torvalds@osdl.org>, linux-arch@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [RFC] timers, pointers to functions and type safety
Message-ID: <20061204114851.GA25859@elte.hu>
References: <20061201172149.GC3078@ftp.linux.org.uk> <1165064370.24604.36.camel@localhost.localdomain> <20061202140521.GJ3078@ftp.linux.org.uk> <1165070713.24604.50.camel@localhost.localdomain> <20061202160252.GQ14076@parisc-linux.org> <1165082803.24604.54.camel@localhost.localdomain> <20061202181957.GK3078@ftp.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061202181957.GK3078@ftp.linux.org.uk>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1414
Lines: 31


* Al Viro <viro@ftp.linux.org.uk> wrote:

> > This is going to make a lot of data structures smaller, when the 
> > timer_list is embedded in the structure itself and for the lot, 
> > which ignores the timer callback argument anyway.
> 
> container_of => still lousy type safety.  All over the sodding place.

the question is: which is more important, the type safety of a 
container_of() [or type cast], which if we get it wrong produces a 
/very/ trivial crash that is trivial to fix - or embedded timers data 
structure size all around the kernel? I believe the latter is more 
important.

and we could have a runtime debugging option to tie the type of the 
structure to the timer list entry. For example by using 
__builtin_classify_type(), sizeof() and offsetof() to fingerprint timer 
structs at init_timer time, and then checking for that at container_of() 
time - or something like that. In fact, gcc should really give us a 
better way to categorize types than __builtin_classify_type(). We could 
probably improve the situation by having some global registry of types 
known to the kernel, via a huge switch() around 
__builtin_types_compatible_p().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/