Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210819132416.175644-1-yangyingliang@huawei.com>
 <CAHp75Vd22aP098s9iXCGmBG505dW1vmZgvy3h9NoNA=J-eQ-CQ@mail.gmail.com> <9b848f1c-9acd-243e-2c5b-d489d2427464@huawei.com>
In-Reply-To: <9b848f1c-9acd-243e-2c5b-d489d2427464@huawei.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 20 Aug 2021 12:17:46 +0300
Message-ID: <CAHp75Vdim8S5kMZY1DYSMM-gLbPHoqRcEMD-rcZ1sm9hPeTaOw@mail.gmail.com>
Subject: Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Jonathan Cameron <jic23@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 20, 2021 at 4:52 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
> On 2021/8/20 1:20, Andy Shevchenko wrote:
> > On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
> >> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
> > ...
> >
> >>          ret = clk_prepare_enable(adc->adclk);
> >> -       if (ret)
> >> +       if (ret) {
> >> +               clk_disable_unprepare(adc->pclk);
> >>                  return ret;
> >> +       }
> > Huh?!
> The pclk need be disabled, when enable adclk failed.
>        ^                                                         ^^

Indeed. I'm wondering if those clocks behave like a bulk or any
combination is possible on a working case?

-- 
With Best Regards,
Andy Shevchenko