Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 20 Aug 2021 23:00:30 +1200
From:   Luke Jones <luke@ljones.dev>
Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves
To:     Bastien Nocera <hadess@hadess.net>
Cc:     linux-kernel@vger.kernel.org, hdegoede@redhat.com,
        platform-driver-x86@vger.kernel.org
Message-Id: <U8X4YQ.79I8GZJ1LDW02@ljones.dev>
In-Reply-To: <c19dfdde11754c234ca8a45c4af2187699498ee8.camel@hadess.net>
References: <20210820095726.14131-1-luke@ljones.dev>
        <20210820095726.14131-2-luke@ljones.dev>
        <321afe1a293be3a623a9be53feea3a008e044b31.camel@hadess.net>
        <L0W4YQ.ZVWQDLFJE8NR2@ljones.dev>
        <e7fbcf85f61b5c727a93df07b3bfe1624547067f.camel@hadess.net>
        <c19dfdde11754c234ca8a45c4af2187699498ee8.camel@hadess.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk


On Fri, Aug 20 2021 at 12:51:08 +0200, Bastien Nocera 
<hadess@hadess.net> wrote:
> On Fri, 2021-08-20 at 12:43 +0200, Bastien Nocera wrote:
>>  On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote:
>>  > > Am I going to get bug reports from Asus users that will complain
>>  > > that
>>  > > power-profiles-daemon doesn't work correctly, where I will have
>>  > > to
>>  > > wearily ask if they're using an Asus Rog laptop?
>>  >
>>  > No. Definitely not. The changes to fan curves per-profile need to
>>  > be
>>  > explicitly enabled and set. So a new user will be unaware that 
>> this
>>  > control exists (until they look for it) and their laptop will
>>  > behave
>>  > exactly as default.
>> 
>>  "The user will need to change the fan curves manually so will
>>  definitely remember to mention it in bug reports" is a very 
>> different
>>  thing to "the user can't change the fan curves to be nonsensical and
>>  mean opposite things".
>> 
>>  I can assure you that I will eventually get bug reports from "power
>>  users" who break their setup and wonder why things don't work
>>  properly,
>>  without ever mentioning the changes they made changes to the fan
>>  curves, or anything else they might have changed.
> 
> A way to taint the settings that power-profiles-daemon could catch
> would be fine by me. I absolutely don't want to have to support
> somebody's tweaks until they undo them.

Definitely understood. Do you have something in mind?

>