Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 20 Aug 2021 14:21:05 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: Use 'atomic_inc_return' instead of
 hand-writing it
In-Reply-To: <1091bc38881086be28d561adca042caba234f3f2.1627054657.git.christophe.jaillet@wanadoo.fr>
Message-ID: <nycvar.YFH.7.76.2108201420570.15313@cbobk.fhfr.pm>
References: <1091bc38881086be28d561adca042caba234f3f2.1627054657.git.christophe.jaillet@wanadoo.fr>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 23 Jul 2021, Christophe JAILLET wrote:

> This function logs a warning if the workqueue gets too big.
> In order to save a few cycles, use 'atomic_inc_return()' instead of an
> 'atomic_inc()/atomic_read()' sequence.
> 
> This axes a line of code and saves a 'atomic_read()' call.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 61635e629469..a7fa35245c2e 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -2240,11 +2240,10 @@ static int hidpp_ff_queue_work(struct hidpp_ff_private_data *data, int effect_id
>  	wd->size = size;
>  	memcpy(wd->params, params, size);
>  
> -	atomic_inc(&data->workqueue_size);
> +	s = atomic_inc_return(&data->workqueue_size);
>  	queue_work(data->wq, &wd->work);
>  
>  	/* warn about excessive queue size */
> -	s = atomic_read(&data->workqueue_size);
>  	if (s >= 20 && s % 20 == 0)
>  		hid_warn(data->hidpp->hid_dev, "Force feedback command queue contains %d commands, causing substantial delays!", s);

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs