Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 20 Aug 2021 14:33:13 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Hamza Mahfooz <someguy@effective-light.com>
cc:     linux-kernel@vger.kernel.org,
        =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@riseup.net>,
        Bastien Nocera <hadess@hadess.net>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH v4] HID: logitech-hidpp: battery: provide CAPACITY property
 for newer devices
In-Reply-To: <20210802125232.65188-1-someguy@effective-light.com>
Message-ID: <nycvar.YFH.7.76.2108201433050.15313@cbobk.fhfr.pm>
References: <20210802125232.65188-1-someguy@effective-light.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 2 Aug 2021, Hamza Mahfooz wrote:

> For devices that only support the BATTERY_VOLTAGE (0x1001) feature, UPower
> requires the additional information provided by this patch, to set them up.
> 
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
> ---
> 
> v2: use ARRAY_SIZE() and set voltages[]'s size to 100
> 
> v3: add a check to ensure that exactly 100 elements are in voltages[]
> 
> v4: add a note regarding the voltage curve and introduce a bounds check on
>     the reported voltage

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs