Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1465458pxb; Fri, 20 Aug 2021 06:15:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxazmQtmsV5+tNvGUu1kCgghDJLIXKzeC0mzm3DTegsDb0NzBGzDCq3mL0QbcFAEzm2/6ae X-Received: by 2002:a05:6602:58c:: with SMTP id v12mr4161723iox.1.1629465329881; Fri, 20 Aug 2021 06:15:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629465329; cv=none; d=google.com; s=arc-20160816; b=Q2O/ILPZg0ppfPPbFPTGMZwkLBGKGoDvXP5ltKrOgb8lSfzgJHnuBAlGNGI1+p7wgT MO3pcY995vfvVNhxv62QLNgnaFPO/su9QEu9tGsIdpI9HdTWpllv2LnoKUgD7uvj7wvJ AEtYeLhO0muM7OZuHQUocEGNHENDf1rvkOwDwM0TNKuORASsE2IGkOx5M33TowRYnJOD VS/SAcs2+3jtSRE6MxryzZqXIqNzqBU5xk+Kr7wzUJpJj9P8RIGaq17NAgfc5uW2L2HA a5AkK16vctXtsr09hPS5kwsqqTSrXopeTjQDKF5dM+YIjaiIr4Mt08lcsaUUVtkN6Lde FdAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date; bh=lvjU3kUf66brw5s5nf++gONc2LAPXKFJHC/PNk3y7cc=; b=hDaAUZreUIyVKFj9txvjnNK/t4pnmxvZj3GIsLPMZfLqAx5wcnyjsogBRDHnPVaoiw b3Foa/t5iR4nRHl6QaebWTIwe9D8F8McGqtNrlDK0B0cUNNLfsVmQLOQpHRvfE0vyckz 1NteZMCNFhSLpmlunwSh8o1EC+BoB0MTSesfsO55isjr0YbNuMZdbFw/ShBbEO+2oW4X ysyN3o4wbksA+fAqFPNjOHhPoOBMZafies1sZYfsIGPODXzthr0XT9Ltsjfo1szG9r9W Ny+VOOdogDiedH99FN66wnKoMhFzPrjWVjnGh2PJvJdRB7ZRf9XMdTwTGgiKz+dd3BX5 nhyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si6216653ilk.141.2021.08.20.06.15.18; Fri, 20 Aug 2021 06:15:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240677AbhHTNMz convert rfc822-to-8bit (ORCPT + 99 others); Fri, 20 Aug 2021 09:12:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240739AbhHTNMy (ORCPT ); Fri, 20 Aug 2021 09:12:54 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDE7560F91; Fri, 20 Aug 2021 13:12:15 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH4Jh-006C42-Qa; Fri, 20 Aug 2021 14:12:13 +0100 Date: Fri, 20 Aug 2021 14:12:13 +0100 Message-ID: <87o89sqmz6.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Chester Lin , Rob Herring , s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , Li Yang , Fabio Estevam , Matteo Lisi , Frieder Schrempf , Tim Harvey , Jagan Teki , catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger , "Ivan T . Ivanov" , "Lee, Chun-Yi" Subject: Re: [PATCH 4/8] arm64: dts: add NXP S32G2 support In-Reply-To: References: <20210805065429.27485-1-clin@suse.com> <20210805065429.27485-5-clin@suse.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: afaerber@suse.de, clin@suse.com, robh+dt@kernel.org, s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, shawnguo@kernel.org, krzk@kernel.org, linux@rempel-privat.de, s.riedmueller@phytec.de, matthias.schiffer@ew.tq-group.com, leoyang.li@nxp.com, festevam@gmail.com, matteo.lisi@engicam.com, frieder.schrempf@kontron.de, tharvey@gateworks.com, jagan@amarulasolutions.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, matthias.bgg@gmail.com, iivanov@suse.de, jlee@suse.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Aug 2021 18:26:28 +0100, Andreas Färber wrote: > > Hi Chester et al., > > On 05.08.21 08:54, Chester Lin wrote: > > Add an initial dtsi file for generic SoC features of NXP S32G2. > > > > Signed-off-by: Chester Lin > > --- > > arch/arm64/boot/dts/freescale/s32g2.dtsi | 98 ++++++++++++++++++++++++ > > 1 file changed, 98 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/s32g2.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > > new file mode 100644 > > index 000000000000..3321819c1a2d > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi [...] > > + gic: interrupt-controller@50800000 { > > + compatible = "arm,gic-v3"; > > + #interrupt-cells = <3>; > > + interrupt-controller; > > + reg = <0 0x50800000 0 0x10000>, > > + <0 0x50880000 0 0x200000>, That's enough redistributor space for 16 CPUs. However, you only describe 4. Either the number of CPUs is wrong, the size is wrong, or the GIC has been configured for more cores than the SoC has. > > + <0 0x50400000 0 0x2000>, > > + <0 0x50410000 0 0x2000>, > > + <0 0x50420000 0 0x2000>; > > Please order reg after compatible by convention, and sort > interrupt-controller or at least #interrupt-cells (applying to > consumers) last, after the below one applying to this device itself. > > > + interrupts = > + IRQ_TYPE_LEVEL_HIGH)>; > > + }; > > CC'ing Marc for additional GIC scrutiny, often the sizes are wrong. There is more than just sizes. The interrupt specifier for the maintenance interrupt is also wrong. M. -- Without deviation from the norm, progress is not possible.