Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1488215pxb; Fri, 20 Aug 2021 06:45:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3fuAHIonpD+25MnvvME1Uw79KRc+MW4bUDdjGV2KIdPC+1fqhSHbXBMgsDahHTSORIIYI X-Received: by 2002:a6b:2bd6:: with SMTP id r205mr16317186ior.122.1629467122643; Fri, 20 Aug 2021 06:45:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629467122; cv=none; d=google.com; s=arc-20160816; b=LKnhPQjJnIMG6fKsFPhqATMlCkL4lI5X3hJ9ujUY8pgrXI6B6bgZ/AIdmiS59Q5BcE 4BhALKeyg5XIyYj/a3lpf27daPSsXfBUSbCWLG0bsuyVJ9CfGCn2dVR/Cz1RMIBdLQnB ztAZg7s2BZ2rFsg+Y2EmQdVHqJqhxAu0sU9CWhmkP0ZyWSiK89Xwmz4dVXPpgA2WLHMy Lv4YPWrViI6wVE6VRvYvwu75m+srqX0RchQV4Q19C6DA5Jusuy6fprIXLPFIKeyqAgsT BIzGY4djj76b9EW5F7sD+hp8fWUKlAn8GL87efR78ZkW0j8R5PljfROPkOgl0vQTPQDn qDeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=OFEY4/WIqhPDr7YA/6UzwoAWbbWLMbOTh8nq2XZp3H0=; b=XZWsYgjjIh+dixwPgt2NdenPEr17EQlfj5RoTbRNbAfP9OAZSvj9kbgeePXslewwEa IG9+cU5/ma9zF+ike0736Vl36Cof8DTITcjRnt5rXy3cCr9TcrFg6NQdfC3fpYfh17/K 7lYvxyNzPVVNdmUrM1zTe9jMyUKFP7JYH/xkA6JMAMCEbqyZJa8SHtqGc13gqp+m3tlj 0xHmumN/Fo3E3y4ohA1ahv7U7/jWEydRQMcPMd1eobfiFylITF/97jgRCKVR6yyW/mcR fw4ZN2euClI+7YIVaKFXb4vpFMOhz5i6FdyRNFTOWRHlA/sNHKEnp7hAMYGwwK8pppCO D9Ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si2960490ilb.93.2021.08.20.06.45.10; Fri, 20 Aug 2021 06:45:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240760AbhHTNnz (ORCPT + 99 others); Fri, 20 Aug 2021 09:43:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:57286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbhHTNnv (ORCPT ); Fri, 20 Aug 2021 09:43:51 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D120610FF; Fri, 20 Aug 2021 13:43:08 +0000 (UTC) Date: Fri, 20 Aug 2021 09:43:01 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Jeff Layton , "Eric W. Biederman" , Matthew Wilcox , Andy Lutomirski , David Laight , David Hildenbrand , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Al Viro , Alexey Dobriyan , "Peter Zijlstra (Intel)" , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Petr Mladek , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Kees Cook , Greg Ungerer , Geert Uytterhoeven , Mike Rapoport , Vlastimil Babka , Vincenzo Frascino , Chinwen Chang , Michel Lespinasse , Catalin Marinas , Huang Ying , Jann Horn , Feng Tang , Kevin Brodsky , Michael Ellerman , Shawn Anastasio , Steven Price , Nicholas Piggin , Christian Brauner , Jens Axboe , Gabriel Krisman Bertazi , Peter Xu , Suren Baghdasaryan , Shakeel Butt , Marco Elver , Daniel Jordan , Nicolas Viennot , Thomas Cedeno , Collin Fijalkovich , Michal Hocko , Miklos Szeredi , Chengguang Xu , Christian =?UTF-8?B?S8O2bmln?= , "linux-unionfs@vger.kernel.org" , Linux API , "the arch/x86 maintainers" , "" , Linux-MM , Florian Weimer , Michael Kerrisk Subject: Re: Removing Mandatory Locks Message-ID: <20210820094301.62421e21@oasis.local.home> In-Reply-To: References: <20210812084348.6521-1-david@redhat.com> <87o8a2d0wf.fsf@disp2133> <60db2e61-6b00-44fa-b718-e4361fcc238c@www.fastmail.com> <87lf56bllc.fsf@disp2133> <87eeay8pqx.fsf@disp2133> <5b0d7c1e73ca43ef9ce6665fec6c4d7e@AcuMS.aculab.com> <87h7ft2j68.fsf@disp2133> <87k0kkxbjn.fsf_-_@disp2133> <0c2af732e4e9f74c9d20b09fc4b6cbae40351085.camel@kernel.org> <639d90212662cf5cdf80c71bbfec95907c70114a.camel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Aug 2021 15:32:31 -0700 Linus Torvalds wrote: > I originally thought WARN_ON_ONCE() just to get the distro automatic > error handling involved, but it would probably be a big problem for > the people who end up having panic-on-warn or something. > > So probably just a "make it a big box" thing that stands out, kind of > what lockdep etc does with > > pr_warn("======...====\n"); > > around the messages.. > > I don't know if distros have some pattern we could use that would end > up being something that gets reported to the user? People have started using my trace-printk notice message, that seems to be big enough to get noticed. ********************************************************** ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ** ** ** ** trace_printk() being used. Allocating extra memory. ** ** ** ** This means that this is a DEBUG kernel and it is ** ** unsafe for production use. ** ** ** ** If you see this message and you are not debugging ** ** the kernel, report this immediately to your vendor! ** ** ** ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ** ********************************************************** There's been some talk about making that a more "generic" warning message too. -- Steve