Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC:     "jic23@kernel.org" <jic23@kernel.org>
Subject: RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in
 rzg2l_adc_pm_runtime_resume()
Thread-Topic: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in
 rzg2l_adc_pm_runtime_resume()
Thread-Index: AQHXlPy2YbhEf+HCwkmd/oSp43xT+Kt8bbDQ
Date:   Fri, 20 Aug 2021 14:04:15 +0000
Message-ID: <OSZPR01MB7019F9AF40E5E8626DD0E168AAC19@OSZPR01MB7019.jpnprd01.prod.outlook.com>
References: <20210819132416.175644-1-yangyingliang@huawei.com>
In-Reply-To: <20210819132416.175644-1-yangyingliang@huawei.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kPFm7TYjTblNoVH5uPGoF2JxOld0QlV0Pv2/GGcA6T0R4sdytuSlSWnBvbLM?=
 =?us-ascii?Q?AkUBlfYiC+Vg+SCbHOpZdOpSUkHA6V7E9ikI2tfXzWYlO8v9NoCgqfI60Itc?=
 =?us-ascii?Q?0N+JFS+XdGivCABpcEv6CpyRBemO5rnkW7eHWCCVhfU9c4ZagtA8W+KaGWBB?=
 =?us-ascii?Q?9dPgpJySAXkqt5TW+yhGp5tfcDOc501+jTrQO1RJ1VDgCe176SPBC+0/7I+C?=
 =?us-ascii?Q?LDYmZDpIRyTamgB+FhXkmYmyTwHF4gj1psA7cyGn+vNIGW9ewmgugJNorgoR?=
 =?us-ascii?Q?4so6s6PznQGzdScTo6Hx61IXlWuNTbGAJ+qpMn3XD8j6vkm/MO2qQJ4ef9Od?=
 =?us-ascii?Q?PWVzIVq1JrTzLaRBPHasiBQJ7M2jJ0DT/hEyfliroCzpf3T2aOHQU3MJsmHb?=
 =?us-ascii?Q?8KPBgFwFpRQx1u5G192/V0N0ivF3lroUVgi3PIXuo6NJTk8L1/LOzlbeEW+r?=
 =?us-ascii?Q?aRKS1pgDBWC+3GwvIbL6RBlmW1HpdNEXi8le6yco4D1KxJm//EJF2uhGOvsO?=
 =?us-ascii?Q?lCd/c3bDyp1lTbnvffJTEf1hy3LoC6FXCTYprKVy1pZtlYjMHHMpdYaVIAbU?=
 =?us-ascii?Q?wdlDnMdV9oaSkDQvwCp4yxkj7tyWnymaHdqnxwdoOouDuao6gPQMfiiaDNO1?=
 =?us-ascii?Q?mMmUEwX/tQ+TBXKvjunhNCkNBod3HX0sKLstVN4ySjxc/SaQ+0XjaBdLpg3O?=
 =?us-ascii?Q?3lMOMitxRBsHxKLhmUa71s+SZ2LvsnkXCh+US1cQdLy83fdwnRHl65JNJ92e?=
 =?us-ascii?Q?w6V5UhpPeKOiuDZTKydkaK7diUMwforXN8eats9F//49ZZWFlUYUSTODKoeo?=
 =?us-ascii?Q?0oxlAyuUllOdzWaejs8tgqUBUsXZDDrV+1xd8papTKh1hVWOcdkkkIkG3sEX?=
 =?us-ascii?Q?NLy9utMRYWF+sVOJF8fEU8LJOqQxny70UnjzkecLRinp/GBU1/4Zv32+2/9y?=
 =?us-ascii?Q?h380hNaVqXm+t98AuQdSr3GweDI/FjV4IsKLKIRghPVvHdcH5gOeTmVFeAKu?=
 =?us-ascii?Q?BqVlP8y/SynQdcfPRgY+RrBrw3+neU/rDsBkqCu0aLw4IuLI6lJjeuCeZIEu?=
 =?us-ascii?Q?/ObwWtNZR14xoAEdZg/8+YiKCqHN8W7BuCJB6gCJroOtJjVZY8VlfJZJT3re?=
 =?us-ascii?Q?XfxtxGMr47i5V1D2c2BT2TSL2Iq1q3h1M0hWSMqzv/V7cQRyWTucJA2jFLLE?=
 =?us-ascii?Q?nPGy58roPRU9z7oPegS5WG7VKQgwzyvjkSHJ8Q3IU10ghuyzzeeXovgmYpAq?=
 =?us-ascii?Q?nTtJAScWC6D+ElUMtl51r9bvfHjjDZPxlL19o1kryX02xX6zWVkR9virwHnh?=
 =?us-ascii?Q?Sp6dCyJJ706cHNpkHBJo8Er4?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSZPR01MB7019.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d674edad-aeb0-4fc7-ebdb-08d963e36531
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2021 14:04:15.4290
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KidVLBihJ1l9+WibFXIadmMDYnsY5whhrdkpRgFKvVyEq7NR48JPXB70DI3o2JVC3TyDXBCuI41kGSHtIgC9nRvFODaSd28whoDk+ZqDfnW1PXNiOiCqVQwLgavhENxy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB2546
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yang,

Thank you for the patch.

> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: 19 August 2021 14:24
> To: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org
> Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; jic2=
3@kernel.org
> Subject: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in r=
zg2l_adc_pm_runtime_resume()
>=20
> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume(=
).
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/iio/adc/rzg2l_adc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
With subject line changed to, iio: adc: rzg2l_adc: add missing clk_disable_=
unprepare() in rzg2l_adc_pm_runtime_resume()

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c in=
dex
> 9996d5eef289..c38f43ea624f 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -570,8 +570,10 @@ static int __maybe_unused rzg2l_adc_pm_runtime_resum=
e(struct device *dev)
>  		return ret;
>=20
>  	ret =3D clk_prepare_enable(adc->adclk);
> -	if (ret)
> +	if (ret) {
> +		clk_disable_unprepare(adc->pclk);
>  		return ret;
> +	}
>=20
>  	rzg2l_adc_pwr(adc, true);
>=20
> --
> 2.25.1