Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210820035229.216975-1-daeho43@gmail.com> <20210820035229.216975-2-daeho43@gmail.com>
 <48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org>
In-Reply-To: <48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Fri, 20 Aug 2021 08:23:05 -0700
Message-ID: <CACOAw_xcwZN_H7_zi7iMJh9HpzXnPd67fNAcxhu5UUSmJk7c1Q@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: introduce periodic iostat io
 latency traces
To:     Chao Yu <chao@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 20, 2021 at 3:50 AM Chao Yu <chao@kernel.org> wrote:
>
> On 2021/8/20 11:52, Daeho Jeong wrote:
> > +void iostat_update_and_unbind_ctx(struct bio *bio, int rw)
> > +{
> > +     struct bio_iostat_ctx *iostat_ctx = bio->bi_private;
> > +     int sync_type = bio->bi_opf & REQ_SYNC ? 0 : 1;
>
> int sync_type = bio->bi_opf & REQ_SYNC ? 1 : 0;
>
> Right?

This means just type, not boolean number. So, I set type 0 is sync and
type 1 is async.

>
> >   int f2fs_init_iostat(struct f2fs_sb_info *sbi)
> >   {
> >       /* init iostat info */
> >       spin_lock_init(&sbi->iostat_lock);
> > +     spin_lock_init(&sbi->iostat_lat_lock);
> >       sbi->iostat_enable = false;
> >       sbi->iostat_period_ms = DEFAULT_IOSTAT_PERIOD_MS;
> > +     sbi->iostat_io_lat = f2fs_kzalloc(sbi, sizeof(struct iostat_lat_info),
> > +                                     GFP_KERNEL);
> > +     if (!sbi->iostat_io_lat)
> > +             return -ENOMEM;
>
> What do you think of just embedding iostat_io_lat structure into f2fs_sb_info
> structure? it's minor thing though.
>

I also wanted to do that, but if we embed this type, we need to define
that structure in f2fs.h file.
Is it okay with you?

> Thanks,