Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1638513pxb; Fri, 20 Aug 2021 10:10:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynz4pDLah4TJ1pSYZA0rbq69lUK4s+srmU9iir0qAlG4Diz1ErwhoEern8Ndv875UxJzu9 X-Received: by 2002:a02:2243:: with SMTP id o64mr18829494jao.40.1629479409863; Fri, 20 Aug 2021 10:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629479409; cv=none; d=google.com; s=arc-20160816; b=sLugvzuqGiv84Brgz9Yoxj8rpVWB3ikBI1dyK5Hda5gB/QYXnDFCIXYvkLJi3D6tzz AX1ki4n2Oc6Sa3xAp729Deou+2hfChTp6eQ55DwstOhPlkNgNY3o4gZvEJEGk/U7eyZm xd0+LCmH++ABxIimjFgWVU2O8hNCVRwvKURD+COLr23aLJ97VZxj3bVHuPvjJ9DzeED3 mJeB3CrnvYvHmWpASOFWy4vfEb+gYVY2c8PUFv5QdiU1qpN+j4E5FcXwzQZqGu3STrcu BI7JEDGzbwhNPLpv1ljDbQPeaC8PksVpkkD6o4r+9d63cbV8wSep+CfJfj7wZFH96diP 5gCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=oFvMBCCt7SwCXd2CqR8OXrAwBSbUU169iJ+hQAkAtr8=; b=J7ExA4RbrsPZqycqDFkQuOfpGFeWxdxA25nEupVDRSqjLUWck3EPMauxJzrL0EFlMG 7ZAdbZfP6f3TQBGbcFn26fTy2UvlIruGD/HLLLHvfBgCEAj/bbrgef07fXF6U/ziYoO3 7H8PTyUSFYQsgHfxo+dzVMxFfB/usrMcRa/bCPrXiozn1W+1DbH/mbsDidrJxN21Z8x8 hkP4d8R7ld642CuTJvjVYymMHe/sNxkCXT2HG3q2tTMgsJYD84zG2Sz21J0IBmY0lRlW rhROpoSZGZwVd7yXKe8KHOw1xa7ttSs4LQA5rIX5MkRZRUxSQBowRQiU407iONsYKBXI n5dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="EIPZ4n/d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si7115126ilr.97.2021.08.20.10.09.57; Fri, 20 Aug 2021 10:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="EIPZ4n/d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbhHTRJR (ORCPT + 99 others); Fri, 20 Aug 2021 13:09:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:43712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbhHTRJM (ORCPT ); Fri, 20 Aug 2021 13:09:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9BD2B610CC; Fri, 20 Aug 2021 17:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629479314; bh=6Ad+ilmKXkBYKGB3YDYi+cYk50uXVwyBdAJ/McR8sZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EIPZ4n/dZwsQlmWUpqPYhQwFaRUfzhGvZfKn0PW/OZe7YeEPC3wfWmiLtZ7x2t8z6 kA9XSKb8dF7fKkO5v8Vyec9FF+UhzhULfPQMY9z0BuEeNiK2fGqn8dAVXsM+1cFqb4 4h0EP/SlhD/26WYauS6CFyPzx5YMviKWCukQ/qDYCStTSxfsONu+WkA1rKSUSMFVNP 4KICGbswo34oyUFlnkbNsG2op/SZRWSGhCkP2dhvP/VKI4VWNblD50yYtXzilo9VHX UuZzPjC9qQpuU5D6rlZTH5B0VU11HaZUFEHvrA/0Bg/L+seYwOZpMjCEnQaBKNINZz dfIXM8qQTvS3A== Date: Fri, 20 Aug 2021 10:08:32 -0700 From: Jakub Kicinski To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , Jarkko Nikula , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net 1/1] net: usb: asix: ax88772: move embedded PHY detection as early as possible Message-ID: <20210820100832.4b548200@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210820095243.2452-1-o.rempel@pengutronix.de> References: <20210820095243.2452-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 11:52:43 +0200 Oleksij Rempel wrote: > Some HW revisions need additional MAC configuration before the embedded PHY > can be enabled. If this is not done, we won't be able to get response > from the internal PHY. > > This issue was detected on chipcode == AX_AX88772_CHIPCODE variant, > where ax88772_hw_reset() was executed with missing embd_phy flag. > > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") > Reported-by: Jarkko Nikula > Tested-by: Jarkko Nikula > Signed-off-by: Oleksij Rempel Does not apply to net, please rebase