Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1629386192.git.zhansayabagdaulet@gmail.com>
 <318b946ac80cc9205c89d0962048378f7ce0705b.1629386192.git.zhansayabagdaulet@gmail.com>
 <20210819162953.GN5469@sequoia>
In-Reply-To: <20210819162953.GN5469@sequoia>
From:   Pavel Tatashin <pasha.tatashin@soleen.com>
Date:   Fri, 20 Aug 2021 13:19:23 -0400
Message-ID: <CA+CK2bCfqGsZKr5Fh3pRC6NcyJExxjrg7C6NxQWvZbVa_PeK=Q@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] selftests: vm: add KSM merging time test
To:     Tyler Hicks <tyhicks@linux.microsoft.com>
Cc:     Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>, linux-kselftest@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 19, 2021 at 12:29 PM Tyler Hicks
<tyhicks@linux.microsoft.com> wrote:
>
> On 2021-08-19 21:33:41, Zhansaya Bagdauletkyzy wrote:
> > Add ksm_merge_time() function to determine speed and time needed for
> > merging. The total spent time is shown in seconds while speed is
> > in MiB/s. User must specify the size of duplicated memory area (in MiB)
> > before running the test.
> >
> > The test is run as follows: ./ksm_tests -P -s 100
> > The output:
> >       Total size:    100 MiB
> >       Total time:    0.201106786 s
> >       Average speed:  497.248 MiB/s
> >
> > Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
> > ---
> > v2 -> v3:
> >  - no changes
>
> There were no changes to this patch since v2 so my previous review still
> stands:
>
>  Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>

Thank you for addressing my comments in v2.

Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com>