Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1629386192.git.zhansayabagdaulet@gmail.com>
 <1d03ee0d1b341959d4b61672c6401d498bff5652.1629386192.git.zhansayabagdaulet@gmail.com>
 <20210819163117.GO5469@sequoia>
In-Reply-To: <20210819163117.GO5469@sequoia>
From:   Pavel Tatashin <pasha.tatashin@soleen.com>
Date:   Fri, 20 Aug 2021 13:20:04 -0400
Message-ID: <CA+CK2bB5kC=wVO0g4mC0VVFHhJyuoL_Kd7zqiHrmXC7jwejcWQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] selftests: vm: add COW time test for KSM pages
To:     Tyler Hicks <tyhicks@linux.microsoft.com>
Cc:     Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>, linux-kselftest@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 19, 2021 at 12:31 PM Tyler Hicks
<tyhicks@linux.microsoft.com> wrote:
>
> On 2021-08-19 21:33:43, Zhansaya Bagdauletkyzy wrote:
> > Since merged pages are copied every time they need to be modified,
> > the write access time is different between shared and non-shared pages.
> > Add ksm_cow_time() function which evaluates latency of these COW
> > breaks. First, 4000 pages are allocated and the time, required to modify
> > 1 byte in every other page, is measured. After this, the pages are
> > merged into 2000 pairs and in each pair, 1 page is modified (i.e. they
> > are decoupled) to detect COW breaks. The time needed to break COW of
> > merged pages is then compared with performance of non-shared pages.
> >
> > The test is run as follows: ./ksm_tests -C
> > The output:
> >       Total size:    15 MiB
> >
> >       Not merged pages:
> >       Total time:     0.002185489 s
> >       Average speed:  3202.945 MiB/s
> >
> >       Merged pages:
> >       Total time:     0.004386872 s
> >       Average speed:  1595.670 MiB/s
> >
> > Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
> > ---
> > v2 -> v3:
> >  - address Tyler's feedback
>
> Thanks for incorporating my suggestions! I can confirm that my feedback
> was completely addressed.
>
>  Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>
>
> Tyler

Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com>