Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1684908pxb; Fri, 20 Aug 2021 11:16:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzepbAru6Cyj4QsTCRRI5z/toF2yH1HSqmtdc+7D9PxUTsb6kd7JCNN+bG/MnAnf0xjNDUe X-Received: by 2002:aa7:cb86:: with SMTP id r6mr23829963edt.181.1629483416806; Fri, 20 Aug 2021 11:16:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629483416; cv=none; d=google.com; s=arc-20160816; b=eafBOj/+LalPwHUGmZzK0PWVezJm1T5NcQzFmTXZdZo+uisWfVl8Z0j/98ELcGoSkc oqC50qof6UdVmY/UuabuxsdY1JIpHwm+BJJM5GHeiCW+JoFPFpNsvC1dQJ6lN1F/RdY8 kAIxWRhLhDQIpe3gVB/BrAFlWi880ZVc2xKBMPHf1tg/ZRVkU1KDIB1K41T/VWqkoiEV cxpq76nyffPPq5/QvSUNl+NkkXLhYW8wqtw/60l1cVdM1UfzroVNGvlmLLCsRASrCAoP bh0Map0yUPDkp+MN1rYHgHUK7S97fXLyZnsz2/VQkMaB0Z1GClrrO6ZRP8n4DmixH3aP qBnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date; bh=Ok+HYoeynNF4UVJxtTCbODQKJB3sbRksQfjwI+BoPPw=; b=gE74MH22UvNwsJnjqEhlE2cCFgXlVmRuGvKoiGq6SBr4C1+VxTLuY22GwwvoAUVnnI fQB+C05JxSiNEjxK9gz8Eby0yn/0J1L8kEuci0/sxg0ARa745zSHIgZfIYIkc6UiCsSe r6eJ/tm3TeMl1FO7GaeJX9O1dYWzTzTyP7UiE7Trste1AZQQ9JGGl+F3ZPEU2/pvw2YA w5oo6ifGKRKdPH5j8+oj7WDEWlc5ZpRzUNhbWiALs/3RHHg65fzEyODm4ipE9R1JchYf WjtSQ4QTYPh1C6VsMvE8dshOStAw5RGZ9XanwsB5dlaQLA9QEn9RDoNQM3CUfNNaFMGB C0Ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg32si8052515ejc.294.2021.08.20.11.16.29; Fri, 20 Aug 2021 11:16:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235055AbhHTSPW (ORCPT + 99 others); Fri, 20 Aug 2021 14:15:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:46222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbhHTSPV (ORCPT ); Fri, 20 Aug 2021 14:15:21 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE8A361056; Fri, 20 Aug 2021 18:14:43 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH92P-006Fhq-Uh; Fri, 20 Aug 2021 19:14:42 +0100 Date: Fri, 20 Aug 2021 19:14:41 +0100 Message-ID: <87czq8yodq.wl-maz@kernel.org> From: Marc Zyngier To: Matteo Croce Cc: Eric Dumazet , Thierry Reding , netdev@vger.kernel.org, Linux Kernel Mailing List , linux-riscv , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , Jakub Kicinski , Palmer Dabbelt , Paul Walmsley , Drew Fustini , Emil Renner Berthing , Jon Hunter , Will Deacon Subject: Re: [PATCH net-next] stmmac: align RX buffers In-Reply-To: References: <20210614022504.24458-1-mcroce@linux.microsoft.com> <871r71azjw.wl-maz@kernel.org> <202417ef-f8ae-895d-4d07-1f9f3d89b4a4@gmail.com> <87o8a49idp.wl-maz@kernel.org> <20210812121835.405d2e37@linux.microsoft.com> <874kbuapod.wl-maz@kernel.org> <87wnohqty1.wl-maz@kernel.org> <87fsv4qdzm.wl-maz@kernel.org> <87mtpcyrdv.wl-maz@kernel.org> <87h7fkyqpv.wl-maz@kernel.org> <87fsv4ypfn.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: mcroce@linux.microsoft.com, eric.dumazet@gmail.com, thierry.reding@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, davem@davemloft.net, kuba@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com, drew@beagleboard.org, kernel@esmil.dk, jonathanh@nvidia.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 19:05:57 +0100, Matteo Croce wrote: > > On Fri, Aug 20, 2021 at 7:56 PM Matteo Croce wrote: > > > > On Fri, Aug 20, 2021 at 7:51 PM Marc Zyngier wrote: > > > > > > On Fri, 20 Aug 2021 18:35:45 +0100, > > > Matteo Croce wrote: > > Great. > > So I doubt that the adjustment is needed. > > Does it work with all the frame size? > > > > Last check, are you sure that the bpf program was loaded in the driver > and not as generic XDP? > You can force it as native with "xdpdrv": > > ip link set eth xdpdrv object kernel_passall.o No issue whatsoever with 5.13. M. -- Without deviation from the norm, progress is not possible.