Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Pavel Skripkin <paskripkin@gmail.com>,
        Phillip Potter <phil@philpotter.co.uk>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 2/3] staging: r8188eu: add error handling to ReadFuse
Date:   Sat, 21 Aug 2021 05:59:20 +0200
Message-ID: <3977072.uyyoESeOv6@localhost.localdomain>
In-Reply-To: <CAA=Fs0=xVqe=QqRwyNGzR7y03na+GF0ktrE3GNhOiD-oObse8A@mail.gmail.com>
References: <cover.1629479152.git.paskripkin@gmail.com> <0e2df1ac9e1031824a1cdb7b24594d2d1b99e382.1629479152.git.paskripkin@gmail.com> <CAA=Fs0=xVqe=QqRwyNGzR7y03na+GF0ktrE3GNhOiD-oObse8A@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dear Pavel

On Saturday, August 21, 2021 1:51:57 AM CEST Phillip Potter wrote:
> On Fri, 20 Aug 2021 at 18:07, Pavel Skripkin <paskripkin@gmail.com> wrote:
> >
> > ReadEFuseByte() internally calls rtw_read8() which can fail. To avoid
> > uninit value bugs we should properly handle error sutiation and deliver

sutiation --> situation.

> > the error to caller.
> >
> > To achieve it, some functions now return an int, and the error
> > which could occur in ReadEFuseByte() is handled on the top level.
> >
> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> > ---
> >  drivers/staging/r8188eu/core/rtw_efuse.c      | 46 +++++++++-----
> >  drivers/staging/r8188eu/hal/hal_intf.c        |  6 +-
> >  .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 62 +++++++++++++------
> >  drivers/staging/r8188eu/hal/usb_halinit.c     | 20 ++++--
> >  drivers/staging/r8188eu/hal/usb_ops_linux.c   | 43 +++++++++++--
> >  drivers/staging/r8188eu/include/hal_intf.h    |  6 +-
> >  .../staging/r8188eu/include/rtl8188e_hal.h    |  2 +-
> >  drivers/staging/r8188eu/include/rtw_efuse.h   |  4 +-
> >  drivers/staging/r8188eu/os_dep/usb_intf.c     |  4 +-
> >  9 files changed, 138 insertions(+), 55 deletions(-)
> >

Please change the Subject: ReadFuse --> ReadEFuse() or 
ReadFuse --> ReadEFuseByte().

> 
> Dear Pavel,
> 
> I like the code, just a few things though:
> (1) the comments I made in the previous e-mail r.e. what we actually
> do with the errors, and grouping logically related changes (the rest
> of the usb_read*() changes being in this patch for example).

I agree with Philip on splitting 1/3 into more patches, perhaps one for each
of the three rtw_read*(), but I disagree on merging the usb_read*() changes 
into this. They should go to another patch because they are not strictly
related to "add[ing] error handling to ReadFuse".

Regards,

Fabio

> (2) I got trailing whitespace errors from this patch and the last one.
> For a v2 I would say stripping the whitespace is a good idea too - I
> have submitted many patches myself to this driver that had whitespace
> in - indeed, the original version of my patch series to import the
> driver still had a load as well :-)
> 
> Regards,
> Phil
>