Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4bf2c7360206025731928fa1c8ad95faa9e65ab8.camel@perches.com>
Subject: Re: [RFC PATCH 1/5] checkpatch: improve handling of revert commits
From:   Joe Perches <joe@perches.com>
To:     Denis Efremov <efremov@linux.com>, linux-kselftest@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        Jens Axboe <axboe@kernel.dk>, Jiri Kosina <jkosina@suse.cz>,
        Willy Tarreau <w@1wt.eu>
Date:   Sat, 21 Aug 2021 00:12:38 -0700
In-Reply-To: <7eda27d1-9e9f-dfd6-3a54-6c592a797ea5@linux.com>
References: <20210818154646.925351-1-efremov@linux.com>
         <20210818154646.925351-2-efremov@linux.com>
         <cc5801790fea258e20fa6b7e26de7806ae8e0dda.camel@perches.com>
         <3d347d4b-1576-754f-8633-ba6084cc0661@linux.com>
         <23c8ebaa0921d5597df9fc1d6cbbcc4f354f80c5.camel@perches.com>
         <c31b2007-26a9-34e0-8c9a-8e11a00ce69f@linux.com>
         <ac2587d3d4b7ce87e8922380e36d7864bfb54262.camel@perches.com>
         <7eda27d1-9e9f-dfd6-3a54-6c592a797ea5@linux.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2021-08-21 at 09:47 +0300, Denis Efremov wrote:
> 
> On 8/20/21 1:17 AM, Joe Perches wrote:
> > 
> > And I'm not sure if this particular ERROR is that useful overall.
> 
> I find it useful to check commit-id and that it matches a title.
> It's easy to make a typo in commit-id and get an invalid one.

That's true, but I meant requiring the sha1 hash to contain both
the word "commit" and use ("title").

Looking at checkpatch's errors produced by this GIT_COMMIT_ID
test makes the required form seem a bit too inflexible to me.

For instance: a sha1 hash may be repeated in a commit message where
the first instance has the correct form but the second use is just
the hash and the warning is still produced.