Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp281293pxb; Sat, 21 Aug 2021 02:27:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo7vGCONaTXn12N7ib1pbrHG7fxGLQlRDMu19/dKMW/qSz5pl91ftBmMZJJr5avjJFpK+U X-Received: by 2002:a17:907:b09:: with SMTP id h9mr26221893ejl.278.1629538058673; Sat, 21 Aug 2021 02:27:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629538058; cv=none; d=google.com; s=arc-20160816; b=lmAFUyh/o/Xv/yMaRVJV/mas1CDoR9RhCHSzhjpChtt1EI5ex6BVSIt+vz0J4fGp/d c7loQku3/1YKnGfQSuc2rbHMZgAEZLW4Sex+rwDgI30zUqcX7SK4qhHrn9BuDAsyhuGw MgKGxoJb3lDYHRR/ht+GTfxN2FADihU6c+kCHLjlIC+Cofm8sS62AU4ee82dhP0OzcbG 6z97hoccqVMZwNJQbU7iyVJFJSIC+H49Y5gAh6arukk1PqAQv1i12MdBmbjhU/KYbWPN 6rbqguSlESvHAHTXzBcYZzcKFB2Qx278CNoE1dFFfqmIlpXdmJTPM7pBSq7ao9xJBsxI A1rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cFqENjx2BQWrtWM5ZT5PkfplNlT1ZpYRy72w6R367EM=; b=x11fPoXCk7v+0jsKCUz+sWGBhG+0gfVE7KWhvIRMNI1xJNxWt99JHeEsXbaOMaXuuB RgF4sL5mUzSto2X57DwnkyMFHNgQwdeQKZczqUrz10Ie7mmT88Bh42tShnPCBcKx+OMO g6Ct+o7D43BzXe9mOh5VDB8ALJ/4RI4Niv5buHQllHDkqsY5nrSa4rSWNtOPlXlIOTeL gYugEfFN5O1WrtO9ToAzWTT2nfzGlV3KgmnGml7l+aI4x5UKIIpFMjHMrXwq7w17pg6J BDQ7goIe0riO9FuztbXheCyuEDj/qOmBvPTL6P4sB/PWP9S3399sfjBxG1W5lJUIl2fF gHqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si9022390edt.589.2021.08.21.02.27.12; Sat, 21 Aug 2021 02:27:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233776AbhHUJ0E (ORCPT + 99 others); Sat, 21 Aug 2021 05:26:04 -0400 Received: from elvis.franken.de ([193.175.24.41]:41941 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233311AbhHUJ0A (ORCPT ); Sat, 21 Aug 2021 05:26:00 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mHNFe-0005Uw-00; Sat, 21 Aug 2021 11:25:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 504C1C081C; Sat, 21 Aug 2021 10:40:52 +0200 (CEST) Date: Sat, 21 Aug 2021 10:40:52 +0200 From: Thomas Bogendoerfer To: Huilong Deng Cc: chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Return true/false (not 1/0) from bool functions Message-ID: <20210821084052.GA3555@alpha.franken.de> References: <20210817025338.3552-1-denghuilong@cdjrlc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817025338.3552-1-denghuilong@cdjrlc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 10:53:38AM +0800, Huilong Deng wrote: > ./arch/mips/kernel/uprobes.c:261:8-9: WARNING: return of 0/1 in function > 'arch_uprobe_skip_sstep' with return type bool > ./arch/mips/kernel/uprobes.c:78:10-11: WARNING: return of 0/1 in > function 'is_trap_insn' with return type bool > ./arch/mips/kvm/mmu.c:489:9-10: WARNING: return of 0/1 in function > 'kvm_test_age_gfn' with return type bool > ./arch/mips/kvm/mmu.c:445:8-9: WARNING: return of 0/1 in function > 'kvm_unmap_gfn_range' with return type bool > > Signed-off-by: Huilong Deng > --- > arch/mips/kernel/uprobes.c | 10 +++++----- > arch/mips/kvm/mmu.c | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]