Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp320681pxb; Sat, 21 Aug 2021 03:43:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTOKTEHc0KwVbLs5DJpC+NpBZAKcvve9W8X+s1/HL9g/g3Dcjpdc/d+8hg5kiMuTymEbdg X-Received: by 2002:aa7:df03:: with SMTP id c3mr26773588edy.348.1629542584848; Sat, 21 Aug 2021 03:43:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629542584; cv=none; d=google.com; s=arc-20160816; b=oLo+r1s62asjzBFkyfEg1CSLCdntpaGw5SEde/p3GSnTOVcynwNIG9usiQgVVUtX60 zDrBTsszLR8lkrnVHmNJowcIVn6vKSFc+XVvSsIS/oH1UeFummTjiWfst4nOnE1eDApS 8RWFiKDSn7KCePbaheqQgeqS2Jws2v7NENgegQEJpN+KjOTxGshhDvhMxulFaG7Cq81A xKWnPOtJfXFMf7HxWj9tCblXL2Nc2HkvhFbrhB/lFb9EhFYHgHXpv0k2CKGNYjCQHWlE xBy8TyH9CVhWSKGZjqrAiTTotiNjU8hX42IS7ifXDp3sTYT8UGfx9Oyarx5aI+uSb8Ax 1LaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NQMIWbCM94IBRXFKUcp/lKiUIi03H2JK4A/6mZ4PcWc=; b=GnIKai8gA4NJE1VRU2LHs/JGIKMJVrsgcrowMUTD8kXSEtv3BUn5404mYTyvFulf7l 3IrHx4Sv/5LEXXUGGJnQMdO4ZDilN3GSz6M/gSEM5KCl+iGLPuGM/XHhBJwk5Da6gdjU iJLYGKkKJltKh1Ydhdy8S9+6PKW45iu0Mcso4shZ+wGg9IMft+cqljcAiE4VPoZdd1wr rGVmyiMDgKnfvqOah3JkM2eecscL1QxB/BYL+xUMukJzCAZ10uPfZfl5sSX4xiJ4qKCq 1FdhzyIHvA9od8drzSOyKPHcCWVf6Wz1FcSTcZ+948DuTV3rvotUgKYX5yld+heL4c+h Ps7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si8461094edl.215.2021.08.21.03.42.13; Sat, 21 Aug 2021 03:43:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234096AbhHUKiH (ORCPT + 99 others); Sat, 21 Aug 2021 06:38:07 -0400 Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:51654 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234065AbhHUKiG (ORCPT ); Sat, 21 Aug 2021 06:38:06 -0400 Received: from pop-os.home ([90.126.253.178]) by mwinf5d73 with ME id kAdR250043riaq203AdR54; Sat, 21 Aug 2021 12:37:26 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 21 Aug 2021 12:37:26 +0200 X-ME-IP: 90.126.253.178 From: Christophe JAILLET To: jic23@kernel.org, lars@metafoo.de, andy.shevchenko@gmail.com, angelo.compagnucci@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] iio: adc128s052: Fix the error handling path of 'adc128_probe()' Date: Sat, 21 Aug 2021 12:37:24 +0200 Message-Id: <85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A successful 'regulator_enable()' call should be balanced by a corresponding 'regulator_disable()' call in the error handling path of the probe, as already done in the remove function. Update the error handling path accordingly. Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052") Signed-off-by: Christophe JAILLET --- drivers/iio/adc/ti-adc128s052.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index 3143f35a6509..83c1ae07b3e9 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -171,7 +171,13 @@ static int adc128_probe(struct spi_device *spi) mutex_init(&adc->lock); ret = iio_device_register(indio_dev); + if (ret) + goto err_disable_regulator; + return 0; + +err_disable_regulator: + regulator_disable(adc->reg); return ret; } -- 2.30.2