Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp392203pxb; Sat, 21 Aug 2021 05:49:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHvg8qxJi342Xd6yqnsz1jIQgzikiIp0S5t7BtfoidV8k3GupZthX5xw350xVThqQM2Lln X-Received: by 2002:a5e:8a4a:: with SMTP id o10mr5816582iom.11.1629550174098; Sat, 21 Aug 2021 05:49:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629550174; cv=none; d=google.com; s=arc-20160816; b=0aVRrI8c4MzFNeKeB9Zq4q59QSbsBzpfT06OehljTN60Oh1S7ywTVIyvYMI1MMzdaJ 9eQPhnz19qm0LwRKRueQTJa45VohqvY6JFyyNSY1oZiDpRIjV3LD9WYAyRGJu/MF5xrs ZhInBcmiuQDDRbxpqfRb4twJPvhP5/Br8DN/LvZ8+5neF2Z87RE/XpXrFAOXvXSi7tFO aPXVYqaN3wCl4fmHhwnMHehyQDY1r1mkFcFBTBwX36txclKQdIR9e+JfqmPG2gwzUkMR c1YlBEPUPZ4yt2d3G/myIpZeCb7BdMiN9PCbH1UFirzR1gDyZXpEptxoGvJsAUDBJmiu PLiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CsiDXQX5CqxTRDjYxjqIP5WMHOM40KiYSXEpLVVFU1A=; b=AMgzUpNckMakBFEar7b5v04FPze8HZkKF9iWRxFaCFS7WqN/CjGfZ1g5jPXV6a3rLw PmZvjEiCoo0Wm0zBvGSDIhrSo3r4w8sg6s0nkVSTmwP9nT+ObSAnxZ34/3ym2gfMhhEF LhcLuWlu/jU12rurAAdmywENYNA4BMS7fuEwRqxMtFV1NuCr15047YcUFiL001KZiS6p hhkZK09p8jwoB05XpbzBCFI0XQts6QwZulWVdFHmIvVoDOiTrlAWZ0mBRysSQbCYFKYa kyHNJvfbCNvN8JAGLK7dgFamtWodC1J6qikDprzmZ1SjTZO5+506PDvIJ1OPiogO1Cho CrHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="WWMwGIi/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si8541690iog.8.2021.08.21.05.48.59; Sat, 21 Aug 2021 05:49:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="WWMwGIi/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232743AbhHUMjP (ORCPT + 99 others); Sat, 21 Aug 2021 08:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbhHUMjN (ORCPT ); Sat, 21 Aug 2021 08:39:13 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A2D7C061575; Sat, 21 Aug 2021 05:38:34 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z2so26647979lft.1; Sat, 21 Aug 2021 05:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CsiDXQX5CqxTRDjYxjqIP5WMHOM40KiYSXEpLVVFU1A=; b=WWMwGIi/b21LZpvv/cS/fjlWSHCpJw3bHeWU/+5/AT4GwzvHKlW9cMNl7Np3tmk0h9 uXcKGAJ6rv/rdECycldq5oDMpnrwWB3y5l4vmbnRX43QUImMvKZGEl7p7f5TjHOsHPfY pNhmKczJsLLlShgDh9wkKsTt2U0w+sKezf9S/jdTEhm4N1mNrC2bse+C4oGKS3mFryg+ LSHfs6o8utKohNPh6ARmlNv22bq+MEEBgjMBu5qaS99LVEnQ3kIYrIuaLNOtpq4Y8D2R GC6aJ9FnqIB9uDSCWRySMymLhVEEOCHKthAxmvXG+Z42dRKUhNud9moEbdZvJZTuGAAP QcCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CsiDXQX5CqxTRDjYxjqIP5WMHOM40KiYSXEpLVVFU1A=; b=J9IEb21T/5n6L1vPr3A672HYSz5NNg0qT0/3yU+3UGDBqa7sVP1afiyAzgXlDFRhJt crWPsxGOX7ta7e2HNJixNMtoNGv2S0mUfcLsnbdBHR0eejS8hTX0Wr1PvcE1aCUfE3kK TiJw80TEHI/ssuvnujRFiRdpLaVJZz7szf0sOzZ6xh3Dep64TxI8r17LiyZ5Efx8Mjwk bUmcTyyc5A3ZSdJ/YTzlbgIeY3TCImcwyeqiuMmDjmYBmq8F2WmupyrOUObB8df630WS fY4YTFsanbjzy9ei0ZWC5H3TxGGbmeV1N1mFXyfmGTHVSerKEfjSILlpqIe2RX07Cbgi i6vw== X-Gm-Message-State: AOAM530ZEYpLIRuxJcNd1X9KE+B4ifGjQstxKqXK1+U92sKru7D/+hqn 9m5LqBu4yhhqpaupqKH/8YjpfPe3P5KcfR/u X-Received: by 2002:ac2:484a:: with SMTP id 10mr1648015lfy.21.1629549512342; Sat, 21 Aug 2021 05:38:32 -0700 (PDT) Received: from [192.168.0.13] (broadband-46-242-116-145.ip.moscow.rt.ru. [46.242.116.145]) by smtp.gmail.com with ESMTPSA id w6sm908269lfk.163.2021.08.21.05.38.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Aug 2021 05:38:31 -0700 (PDT) Subject: Re: [PATCH v27 00/10] NTFS read-write driver GPL implementation by Paragon Software To: Theodore Ts'o , "Darrick J. Wong" Cc: Konstantin Komarov , linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz, aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org, joe@perches.com, mark@harmstone.com, nborisov@suse.com, linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com, dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org, andy.lavr@gmail.com, kari.argillander@gmail.com, oleksandr@natalenko.name References: <20210729134943.778917-1-almaz.alexandrovich@paragon-software.com> <20210729162459.GA3601405@magnolia> From: Yan Pashkovsky Message-ID: <2399771e-8222-267d-1655-c84a1401f2cd@gmail.com> Date: Sat, 21 Aug 2021 15:38:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Konstantin, I would *strongly* encourage you to try running fstests, > about 60 seconds into a run, we discover that generic/013 will trigger > locking problems that could lead to deadlocks. Seems like it's a real issue. I was using new HDD and ntfs3-dkms (v26) in Arch and faced locking while was doing rsync: [ 5529.507567] INFO: task kworker/0:1:18 blocked for more than 1105 seconds. [ 5529.507580] Tainted: P OE 5.13.4-arch1-1 #1 [ 5529.507584] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 5529.507586] task:kworker/0:1 state:D stack: 0 pid: 18 ppid: 2 flags:0x00004000 [ 5529.507598] Workqueue: usb_hub_wq hub_event [ 5529.507612] Call Trace: [ 5529.507615] ? out_of_line_wait_on_bit_lock+0xb0/0xb0 [ 5529.507631] __schedule+0x310/0x930 [ 5529.507641] ? out_of_line_wait_on_bit_lock+0xb0/0xb0 [ 5529.507648] schedule+0x5b/0xc0 [ 5529.507654] bit_wait+0xd/0x60 [ 5529.507661] __wait_on_bit+0x2a/0x90 [ 5529.507669] __inode_wait_for_writeback+0xb0/0xe0 [ 5529.507680] ? var_wake_function+0x20/0x20 [ 5529.507689] writeback_single_inode+0x64/0x140 [ 5529.507699] sync_inode_metadata+0x3d/0x60 [ 5529.507712] ntfs_set_state+0x126/0x1a0 [ntfs3] [ 5529.507738] ni_write_inode+0x244/0xef0 [ntfs3] [ 5529.507764] ? pagevec_lookup_range_tag+0x24/0x30 [ 5529.507772] ? __filemap_fdatawait_range+0x6f/0xf0 [ 5529.507785] __writeback_single_inode+0x260/0x310 [ 5529.507795] writeback_single_inode+0xa7/0x140 [ 5529.507803] sync_inode_metadata+0x3d/0x60 [ 5529.507814] ntfs_set_state+0x126/0x1a0 [ntfs3] [ 5529.507834] ntfs_sync_fs+0xf9/0x100 [ntfs3] [ 5529.507857] sync_filesystem+0x40/0x90 [ 5529.507868] fsync_bdev+0x21/0x60 [ 5529.507874] delete_partition+0x13/0x80 [ 5529.507882] blk_drop_partitions+0x5b/0xa0 [ 5529.507889] del_gendisk+0xa5/0x220 [ 5529.507895] sd_remove+0x3d/0x80 [ 5529.507907] __device_release_driver+0x17a/0x230 [ 5529.507918] device_release_driver+0x24/0x30 [ 5529.507927] bus_remove_device+0xdb/0x140 [ 5529.507937] device_del+0x18b/0x400 [ 5529.507943] ? ata_tlink_match+0x30/0x30 [ 5529.507949] ? attribute_container_device_trigger+0xc5/0x100 [ 5529.507959] __scsi_remove_device+0x118/0x150 [ 5529.507967] scsi_forget_host+0x54/0x60 [ 5529.507978] scsi_remove_host+0x72/0x110 [ 5529.507988] usb_stor_disconnect+0x46/0xb0 [usb_storage] [ 5529.508003] usb_unbind_interface+0x8a/0x270 [ 5529.508010] ? kernfs_find_ns+0x35/0xd0 [ 5529.508017] __device_release_driver+0x17a/0x230 [ 5529.508027] device_release_driver+0x24/0x30 [ 5529.508036] bus_remove_device+0xdb/0x140 [ 5529.508044] device_del+0x18b/0x400 [ 5529.508050] ? kobject_put+0x98/0x1d0 [ 5529.508062] usb_disable_device+0xc6/0x1f0 [ 5529.508073] usb_disconnect.cold+0x7e/0x250 [ 5529.508085] hub_event+0xc7b/0x17f0 [ 5529.508099] process_one_work+0x1e3/0x3b0 [ 5529.508109] worker_thread+0x50/0x3b0 [ 5529.508115] ? process_one_work+0x3b0/0x3b0 [ 5529.508122] kthread+0x133/0x160 [ 5529.508127] ? set_kthread_struct+0x40/0x40 [ 5529.508133] ret_from_fork+0x22/0x30 [ 8440.627659] blk_update_request: I/O error, dev sdd, sector 256017240 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 8440.627667] ntfs3: 165 callbacks suppressed [ 8440.627667] ntfs3: sdd1: failed to read volume at offset 0x1e84f6b000 [ 8440.627673] blk_update_request: I/O error, dev sdd, sector 256017240 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 8440.627676] ntfs3: sdd1: failed to read volume at offset 0x1e84f6b000 [ 8440.778355] blk_update_request: I/O error, dev sdd, sector 6293496 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 8440.778384] ntfs3: sdd1: failed to read volume at offset 0xbffff000 [ 8440.778412] blk_update_request: I/O error, dev sdd, sector 6353096 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 8440.778428] ntfs3: sdd1: failed to read volume at offset 0xc1d19000 [ 8440.778441] blk_update_request: I/O error, dev sdd, sector 6353096 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0 [ 8440.778452] ntfs3: sdd1: failed to read volume at offset 0xc1d19000 [ 8440.778459] ntfs3: sdd1: ntfs_evict_inode r=0 failed, -22.