Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp395073pxb; Sat, 21 Aug 2021 05:54:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkM6AP3RvVBcUEKe1KOmMgd5HDlwxefkFOQsr0OikRAdslR0XlkrjJivmRIeMdHqiktHLe X-Received: by 2002:a05:6402:1c03:: with SMTP id ck3mr27665756edb.312.1629550488296; Sat, 21 Aug 2021 05:54:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629550488; cv=none; d=google.com; s=arc-20160816; b=mevEz6h8FyINbXEOuZ/fuRsqAJKpyRM6tcleNDPzL4MSgC6cz24d4u6o7CFimBYSVi 19J+2LgGjdeo2OSbkqhOKm0+8+fCa3YDKDXe0IY+zqpBRXoG3k0PYTKBk4jKtr0EzKq9 LmLRLoLvHbTr3BEcdoHKZ9LN013x7fuyLtmmA+CrewbBVNlPjbhx/hGrfL7XYjW4Ji/m F7KV32s8G+NZw/xEymfZdd0qmeUvCrZ2ILP6Z4GtvdCupl+uQMhgxeuH7BxFv93AlJZV Kag2jy7qaxBCijIIehn0gL4SejNrFabNQDv8MN2lF9yJiYpu3mr+OHmsjrsTaYXD2WPD e2aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=NmTocTHQLxRyL4vdXRhkMkO6CoNzzhRog4DVrpDy12o=; b=jCXR+eiR3mpKXGF41xyRMgPMeMMJURTF5uRp7uQGCan6IFOPd45FIqverw5zthx3au V5t+M2Q5n5nAwQOFgJBAfACmD2F4iZxEXOnWBZBUWPnrOYOlmQouNLx/pRlXZgGOx1/u NGfclLeKx8pHro7HUExDyOF//OdqM/WdPAMdJs1wzd+q5pkYO54xj4qvu+D0b0K70FZO WGNsT18IRhFkZLdGAbVLD95ZwtsLBuIJdZB7zruURi6URHG0Daqv5wwJgp4Fydpno4Fn kGGsbTHz3P8JHkwWr9x7/X/R2jQR92JltWJLBpjxWga2pqQC2u19i0tUtG60m53ovcXI 80WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si214551edz.215.2021.08.21.05.54.24; Sat, 21 Aug 2021 05:54:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbhHUMu1 (ORCPT + 99 others); Sat, 21 Aug 2021 08:50:27 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:34844 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhHUMu1 (ORCPT ); Sat, 21 Aug 2021 08:50:27 -0400 Received: from localhost (unknown [192.168.167.16]) by lucky1.263xmail.com (Postfix) with ESMTP id C3B4BD772A; Sat, 21 Aug 2021 20:49:43 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P704T139881080669952S1629550173496538_; Sat, 21 Aug 2021 20:49:34 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: jon.lin@rock-chips.com X-SENDER: jon.lin@rock-chips.com X-LOGIN-NAME: jon.lin@rock-chips.com X-FST-TO: heiko@sntech.de X-RCPT-COUNT: 7 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jon Lin To: Heiko Stuebner Cc: Jon Lin , Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] spi: rockchip-sfc: Remove redundant IO operations Date: Sat, 21 Aug 2021 20:49:25 +0800 Message-Id: <20210821124925.6066-1-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coherent dma buffer is uncached and memcpy is enough. Signed-off-by: Jon Lin --- drivers/spi/spi-rockchip-sfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c index 7c4d47fe80c2..81154a8836fc 100644 --- a/drivers/spi/spi-rockchip-sfc.c +++ b/drivers/spi/spi-rockchip-sfc.c @@ -453,7 +453,7 @@ static int rockchip_sfc_xfer_data_dma(struct rockchip_sfc *sfc, dev_dbg(sfc->dev, "sfc xfer_dma len=%x\n", len); if (op->data.dir == SPI_MEM_DATA_OUT) - memcpy_toio(sfc->buffer, op->data.buf.out, len); + memcpy(sfc->buffer, op->data.buf.out, len); ret = rockchip_sfc_fifo_transfer_dma(sfc, sfc->dma_buffer, len); if (!wait_for_completion_timeout(&sfc->cp, msecs_to_jiffies(2000))) { @@ -462,7 +462,7 @@ static int rockchip_sfc_xfer_data_dma(struct rockchip_sfc *sfc, } rockchip_sfc_irq_mask(sfc, SFC_IMR_DMA); if (op->data.dir == SPI_MEM_DATA_IN) - memcpy_fromio(op->data.buf.in, sfc->buffer, len); + memcpy(op->data.buf.in, sfc->buffer, len); return ret; } -- 2.17.1