Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp426220pxb; Sat, 21 Aug 2021 06:45:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUHlqlfYG8Le4gQC7vC+2G6WH6P85ZCJYjylMDYuvMIKeLJNgdTrxSgbGua4qqKuFXoFqe X-Received: by 2002:a5e:8e4c:: with SMTP id r12mr20005134ioo.73.1629553539252; Sat, 21 Aug 2021 06:45:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629553539; cv=none; d=google.com; s=arc-20160816; b=MZPcCEg6/WBi/xUS2lHAkLdxbFNj6mxHdLvS1sUTjs4w5+ig34t3Vj5vulmFEFkiK/ eZjNtUbEctI1YKX/WKbL+dRS+oq8adl2VuUEE4LBKSq6X2lVtRmvk9y1osZUK4z6YrBi L0NhO8jj/AowtDFqL8qBzlzClF5QDunb0oju8gK/JLFQrVoN44S68XgXIDck43cO4Vnl 6iW7zcf4sXO8uDklgtq+yPqyOnYfXCOEUlNncgpzRUiLQsvkhGf6jO/xTQpdKfHAOehm Mu37w9Xzz0Py8uaeGVoagM4nTTWjGzUKU5ObDLmwx2GfXRGO5h7Xc5j6EWkfAf846NDx oZFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uw7aN7lfs0C03Rj2YgAtsSHpPr93tKVvkhtBhU3EaV4=; b=MWcfmRoU1VIKXQ10PtsKE0kniWMS6oHEUKmb8sM6ba9ziRcAhwViv85FnPifXBW0mS lNap6pyCGrMTR2BUgoYDsPr/pL6CLcd9ftUnReS7XUvgqAdnf5HTqDxrYpxddf1EI2oN 6jVwepoOZwRtzhLXui9wbDI/C2wzQ04kRz9AJb/eW6Zya+DzBhNugAfY7uIHtjmDqJ/6 E2AZpkHl3LQ4Mc8qR9a5p/aOjUNY6e8OhTCi1Dewi8WddQOiiEE8cw4ys/2xENktGKsg uo6LvbC5WwBIXxudgs/AzlVW48nAPps5/1CmmHI9njfZGb4lkAf2/FmCG1Gp7cLEEDYd rWtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KerdWP+O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si11577293ilu.56.2021.08.21.06.45.27; Sat, 21 Aug 2021 06:45:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KerdWP+O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234549AbhHUNnm (ORCPT + 99 others); Sat, 21 Aug 2021 09:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234520AbhHUNnk (ORCPT ); Sat, 21 Aug 2021 09:43:40 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C56AC061756 for ; Sat, 21 Aug 2021 06:43:01 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id bq25so26047020ejb.11 for ; Sat, 21 Aug 2021 06:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uw7aN7lfs0C03Rj2YgAtsSHpPr93tKVvkhtBhU3EaV4=; b=KerdWP+OraMwIr7d7Aabo37FJBLYFSdftGQHrpSF4wyg1W0BYjMSH35VqNfHX010Ar 95MLW3kIG8sF3ctPYbjpFFdG0opV/dMg1LszEKcE0iS4hUDbIgLadtEwz5yajNSNiHGO 4Jqo3flRJzS1uW4aML7tcMZpAYqR6Sct1fk3hE7S+UmtdtqBeL3COaaCstG3PVOg9RMd wWAT105+Nw+d6Z+Oa7bRuy+WZMNhlVRHvmqOrph+cqxB6CKL7ZqsKxnC5xkBhkFClpgg iBNKHbemJDGym1Tv48ibzQe/PY+wd2icq0pubPBDUsrA+dtL7qUKD+A4s3lJfu9gaadp DpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uw7aN7lfs0C03Rj2YgAtsSHpPr93tKVvkhtBhU3EaV4=; b=VOeAkVUjAov3rynwoKxRGIv5yXpSntlpMtCpkBueWz3KOZ4HY0svX5b8kkdbabq7P8 4fysEsu/fiBPTMDsaNmdTjAdbV/U4+YYNXd0KOmPZq1Yb+IxLlqhrSq+XMvakAvz01ax KfgRATnbkPTDxdWv397tVkfz10xyQz3g+zysh3o5TWcUUuIE8SvwFtBRoQJl8Y9hkaJ4 D3w1z+WQfpX8OzIOp1KzXQ0FZo7fNXK19UjOkSMlwYlLeZRBdSRg2OO8NYIYXESWilMf o8r3/4eAsv8MCk+Hvrqk/sygF8nZgmlvNeSmcMzfUsTuIR336ZYE8jQm9W5Fn+kPHdFn AwpA== X-Gm-Message-State: AOAM531aC8gFkzDA33T458nRROpLJWBL6QowbEs0mOSf3vXtWKvI+tc6 yZ8Lt38p7xHSNMLJjtQp9UnrEdrN19Z+mg== X-Received: by 2002:a17:906:2ac1:: with SMTP id m1mr27111809eje.518.1629553379905; Sat, 21 Aug 2021 06:42:59 -0700 (PDT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com. [209.85.221.49]) by smtp.gmail.com with ESMTPSA id r11sm4350877ejy.71.2021.08.21.06.42.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Aug 2021 06:42:59 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id z9so18355002wrh.10 for ; Sat, 21 Aug 2021 06:42:59 -0700 (PDT) X-Received: by 2002:adf:e3c7:: with SMTP id k7mr3871045wrm.327.1629553378450; Sat, 21 Aug 2021 06:42:58 -0700 (PDT) MIME-Version: 1.0 References: <20210819100447.00201b26@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210821071425.512834-2-chouhan.shreyansh630@gmail.com> In-Reply-To: <20210821071425.512834-2-chouhan.shreyansh630@gmail.com> From: Willem de Bruijn Date: Sat, 21 Aug 2021 09:42:20 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2 net] ip6_gre: add validation for csum_start To: Shreyansh Chouhan Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pshelar@nicira.com, willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+ff8e1b9f2f36481e2efc@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 21, 2021 at 3:14 AM Shreyansh Chouhan wrote: > > Validate csum_start in gre_handle_offloads before we call _gre_xmit so > that we do not crash later when the csum_start value is used in the > lco_csum function call. > > This patch deals with ipv6 code. > > Fixes: Fixes: b05229f44228 ("gre6: Cleanup GREv6 transmit path, call common > GRE functions") > Reported-by: syzbot+ff8e1b9f2f36481e2efc@syzkaller.appspotmail.com > Signed-off-by: Shreyansh Chouhan Reviewed-by: Willem de Bruijn