Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp449662pxb; Sat, 21 Aug 2021 07:22:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwScd2ffkTtTaXcU4kke1+Co1zancv5IfO/+hpWcYN4z7kuy8pLs7Gvw6BvqgisewBWwAUq X-Received: by 2002:a50:d795:: with SMTP id w21mr28208820edi.112.1629555727498; Sat, 21 Aug 2021 07:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629555727; cv=none; d=google.com; s=arc-20160816; b=M+pRbtSz9r7rqf39U3Y+2NyNR1hk0/lTD53mGgCvPOES6ONm6RTQc6WEx+NF8S/RmL DkPN6f9ZWxrpVl3EYpcQ9Qjc4wciYb7DG537tY5iW/0SHQAfsKd+Uf3njGvD0gsTtz/x auTRFwoVRcartxuh5q01gqr70Eng5AbO6pR67HUCn0vdbdZcZYVvxY4XbSmqcWpF2EJ4 8/UgSmTD7BSn+6lFjrkdKr/cSig+LhX6+5jZdX/RjlZwavHHPHdGDMzN36tKads4LtFT lxc9ajSgSUkd+oRM3bXASRDx+dUlrNJPaNWie/egYskEVeWV8QOeEwsKuRPbmwy155kl +3JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4BEOSYks7kKTIJey8qCXq/FjaQ8h7AUNhWZJcjwIWNU=; b=kLLY1Y2PQGDFdSSKTqcDuZUcfUkPex+x7Hh3AUs9CyIlEpXeAGgHo+9GfYYEtZ+sk8 jGhj8upJf9TXlMfxQKoSW+/Ht13k42Ag4mhWP51mKQzyiIBu65APN8FwasLWugITWaFb JaZ6XFZD0BrQ29gLvOaXM4oMchvQa06IzyP27SUk+IAeU0LjS7cfMtzC6lj9w4bLXyoh /DBGUyAVQFrZ1k/8shLr0uS1yDhD2sKofleYGguAs/kPD6Hma5oSqTjuihFS7ZAphJJd ZiOwBgzBKuwyRcFCvtjOWj+yVvwqRQ2v7/eeGOSXZnN6QOGZCnDA8GhlrQBwbmokjFd4 NtOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s3mgcInI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si9405040edv.129.2021.08.21.07.21.42; Sat, 21 Aug 2021 07:22:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s3mgcInI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbhHUOUf (ORCPT + 99 others); Sat, 21 Aug 2021 10:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbhHUOUb (ORCPT ); Sat, 21 Aug 2021 10:20:31 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED8A6C061575 for ; Sat, 21 Aug 2021 07:19:51 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id i21so11248550pfd.8 for ; Sat, 21 Aug 2021 07:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4BEOSYks7kKTIJey8qCXq/FjaQ8h7AUNhWZJcjwIWNU=; b=s3mgcInIvBRJt3ELH3xZBXGzK/FWLP0b1agTD5IFB07W2zkrGVSwD6+s5KGtPPCcAH wfQ2XlLNwOp1AoD/FyOaGmxG2N/Vf/LyiQgFvFBKfm5SPcRbtK+5ItneaG1qMy0j1VIU yGK1xHngjTzKWUI09kNloMPdT0jA2QhwpGDsFlA89ciQJTMAcX9boHGWdfVKeTtlQ9ab iJObsOQw0woXiyVXDi+WMCAixC/6bItB/sizFmTeLsgkuTVqmf8Rbef3EmlEIXDgTtAZ g+NIkB1yPcxAHWJ4mz+nxNGI6tLmg9G+npu7SFaFc/WmOLFZjuvutELn849ztvd6vjIX lNpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4BEOSYks7kKTIJey8qCXq/FjaQ8h7AUNhWZJcjwIWNU=; b=uOQZ/zjfdlrK5QmcIt995q/hzomifYm0sNVP5TjAAcRn/ZZCaxXKBPUsij5C5XNpWB MEXy6fH5ZplIYWwJLoyxTXiXO7PAGzHZgRV1LPIomzaEopa+2Rh+kaSlhBtkgTD6VmZl Q0tAp9wLsGuHyRmYGAnGkNbrZP7F/9jLArBo4ZksZB16tmOgelh8xwKc9481h3cs1cFP bqvZsdYzRjBGftGjtpX7aphSEeaqXP7GtNdn1A8ujY67o8o3LAwuMK5gWRwsv6EInjfr soA4/84oS3eD/L9wq3xNK5W0VLEIeefV7HbwDhhOQYbrbQqzKU79uBF7nmDPVjBR9Xjb sisw== X-Gm-Message-State: AOAM5314Ff/Hz83OnjVJFetky7PYOOF2RjpIB5sR4i6raGWdjBSArxiq hzIkBTWrGkSlgiQFWpcKnEA= X-Received: by 2002:a63:496:: with SMTP id 144mr23544336pge.353.1629555591510; Sat, 21 Aug 2021 07:19:51 -0700 (PDT) Received: from localhost ([49.207.137.16]) by smtp.gmail.com with ESMTPSA id r17sm12992641pgu.8.2021.08.21.07.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Aug 2021 07:19:51 -0700 (PDT) Date: Sat, 21 Aug 2021 19:49:49 +0530 From: Aakash Hemadri To: Larry Finger Cc: Greg Kroah-Hartman , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Message-ID: <20210821141949.55l7zcjifbxv6pao@xps.yggdrasil> References: <8bc15e51751c26fd19428f3b4976b7495feecd34.1629360917.git.aakashhemadri123@gmail.com> <58069e38-a457-9fcc-0a9a-6bfe8723a178@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58069e38-a457-9fcc-0a9a-6bfe8723a178@lwfinger.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/08/20 04:38PM, Larry Finger wrote: > This patch is correct, but I prefer that you use be16_to_cpu() rather than > ntohs(). I think it makes the code easier to read. Sure Larry, Will use be16_to_cpu() Thanks, Aakash Hemadri