Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210821000508.79422-1-phil@philpotter.co.uk> <ac672cfe-038d-2fe9-0ac6-904ad7761b54@lwfinger.net>
In-Reply-To: <ac672cfe-038d-2fe9-0ac6-904ad7761b54@lwfinger.net>
From:   Phillip Potter <phil@philpotter.co.uk>
Date:   Sat, 21 Aug 2021 18:10:02 +0100
Message-ID: <CAA=Fs0myhWsn147t4pFfFc=QNc0-4jZaAeREqLGMZ-xN+LNVPg@mail.gmail.com>
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Martin Kaiser <martin@kaiser.cx>,
        Michael Straube <straube.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 21 Aug 2021 at 15:45, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 8/20/21 7:05 PM, Phillip Potter wrote:
> > Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> > from core/rtw_efuse.c, as the function is defined in full directly
> > after this and therefore this forward declaration is redundant.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> >   drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> > index decccf7622f0..45b757ab64e1 100644
> > --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> > +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> > @@ -29,12 +29,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
> >   #define REG_EFUSE_CTRL              0x0030
> >   #define EFUSE_CTRL                  REG_EFUSE_CTRL          /*  E-Fuse Control. */
> >   /*  */
> > -
> > -bool
> > -Efuse_Read1ByteFromFakeContent(
> > -                     struct adapter *pAdapter,
> > -                     u16 Offset,
> > -             u8 *Value);
> >   bool
> >   Efuse_Read1ByteFromFakeContent(
> >                       struct adapter *pAdapter,
> >
>
> Phil,
>
> There a number of such forward references immediately followed by the actual
> routine. I removed some of these when the driver was in the GitHub repo, but I
> missed a few.
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry
>

Dear Larry,

Thanks for this, I ended up doing a V2 that declares the function as
static as well. No doubt there will be others like this - I just
picked this one off as I happened to notice it :-)

Regards,
Phil