Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210821151459.26078-1-Larry.Finger@lwfinger.net>
In-Reply-To: <20210821151459.26078-1-Larry.Finger@lwfinger.net>
From:   Phillip Potter <phil@philpotter.co.uk>
Date:   Sat, 21 Aug 2021 18:19:44 +0100
Message-ID: <CAA=Fs0=8mr_+wBERVSbJD-5HYDLo3pYB8P51xxo96b-nod=h6g@mail.gmail.com>
Subject: Re: [PATCH] staging: r8188eu: Make mult-byte entities in dhcp header
 be big endian
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 21 Aug 2021 at 16:15, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> The 16- and 32-bit quantities in the dhcp message definition must be
> big endian.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> This patch will set up all the reset of the endian warnings,
>
> Larry
> ---
>
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index ee52f28a1e56..62a672243696 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -640,16 +640,16 @@ struct dhcpMessage {
>         u_int8_t hlen;
>         u_int8_t hops;
>         u_int32_t xid;
> -       u_int16_t secs;
> -       u_int16_t flags;
> -       u_int32_t ciaddr;
> -       u_int32_t yiaddr;
> -       u_int32_t siaddr;
> -       u_int32_t giaddr;
> +       __be16 secs;
> +       __be16 flags;
> +       __be32 ciaddr;
> +       __be32 yiaddr;
> +       __be32 siaddr;
> +       __be32 giaddr;
>         u_int8_t chaddr[16];
>         u_int8_t sname[64];
>         u_int8_t file[128];
> -       u_int32_t cookie;
> +       __be32 cookie;
>         u_int8_t options[308]; /* 312 - cookie */
>  };
>
> --
> 2.32.0
>

Nice, thanks.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil