Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/2] objtool: remove redundant len value from struct
 section
From:   Joe Lawrence <joe.lawrence@redhat.com>
To:     x86@kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>,
        Andy Lavr <andy.lavr@gmail.com>
References: <20210820194453.395548-1-joe.lawrence@redhat.com>
 <20210820194453.395548-3-joe.lawrence@redhat.com>
Message-ID: <7ca86dcb-65f8-006b-0628-a79fb4defe40@redhat.com>
Date:   Sat, 21 Aug 2021 21:17:11 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210820194453.395548-3-joe.lawrence@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/20/21 3:44 PM, Joe Lawrence wrote:
> [ ... snip ... ]
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> [ ... snip ... ]
> @@ -307,8 +307,9 @@ static int decode_instructions(struct objtool_file *file)
>  			insn->offset = offset;
>  
>  			ret = arch_decode_instruction(file->elf, sec, offset,
> -						      sec->len - offset,
> -						      &insn->len, &insn->type,
> +						      sec->sh.sh_size - offset,
> +						      &insn->sec->sh.sh_size,
> +						      &insn->type,
>  						      &insn->immediate,
>  						      &insn->stack_ops);
>  			if (ret)

Nack!  Not sure what I was thinking here.  It was Friday afternoon, so I
probably wans't.

Changing insn->len to insn->sec->sh.sh_size is obviously bogus.  I'll
correct this part of the patch, do better testing and post v3 on Monday.

Thanks to Andy for reporting.
-- 
Joe