Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp823203pxb; Sat, 21 Aug 2021 20:32:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2W+Y4OhGWYbuJNDX4XxNtdW54cmDZMxSBWjW8DsOUUskbt+tpEt8800P3eLBnA07sDxB4 X-Received: by 2002:a05:6402:51cf:: with SMTP id r15mr30558231edd.211.1629603162597; Sat, 21 Aug 2021 20:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629603162; cv=none; d=google.com; s=arc-20160816; b=wWwjmyy2cmwIZ7C8V7AwOD1/vMYKW37Xyd006rgSUXRvg/+BdKJ/oGMceWcEBCyTOt 6o2/S1/R+4ZJZRCgwoNlxHQq504mg46ezJPgkQBEs1u2bPs8HInRfMTa97CzSSwxVuRr /XCOxT5VV1vu4X68GvP3x6RGEDNEKFz+yB+qHm982OvmixwrLhp8AcDhNZTXWYWdC5x6 DdDANJvAsRvSfkx4fJMhdfPPutBgZ2K4Uqo6LU9kaEIAbrwvl9rVurCWOiKgwh5N3W2/ iecPPlJVsLetsVeNyjjRZCUODXifz/795eB1rAwujSUVCpoLu5DTV9Kr/JKc2l+NdKdA NVYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wKSq8yN/AdnPn/Z6FgDnItLh8FOW8XFNmrS1szRYJMI=; b=gkL9KYzj0Rp13NFHb8mt2QUdrmKrOvouOxAMzxAxtVJTvDgnaO+Sm+qstIxHQRFHL4 cwnvKNi50QkJBeKNY+/uCENoKeJjurmI6zWoK940rR1PNbLNDec0FICjZ3qm8TzFShqh Ls2bsTcgi3XIwSmy7btzfwMVrn7grrMBFAbeuyRHDpaOu1ZUsfanVrrN0+bkWoeBlYGf DkMyPGL5mvU+5l1uzlJVVWq952f37U31n3H/LCYiOk5Qv539KA0krynSSal4vTp5D9y0 kd/62RRddgWJYx5VwQn2skh6pO/M+AC7rHdtGlPkiUyxOI2i3roMs2K0NebkXfuSQzR3 oWeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg19si12469170ejc.484.2021.08.21.20.32.19; Sat, 21 Aug 2021 20:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232440AbhHVD2j (ORCPT + 99 others); Sat, 21 Aug 2021 23:28:39 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:25930 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbhHVD2i (ORCPT ); Sat, 21 Aug 2021 23:28:38 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.5]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee86121c43071f-f215e; Sun, 22 Aug 2021 11:27:45 +0800 (CST) X-RM-TRANSID: 2ee86121c43071f-f215e X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.22.250.151]) by rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id 2ee36121c429ec8-65213; Sun, 22 Aug 2021 11:27:44 +0800 (CST) X-RM-TRANSID: 2ee36121c429ec8-65213 From: Tang Bin To: gregkh@linuxfoundation.org, paul@crapouillou.net, jirislaby@kernel.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux@prisktech.co.nz Cc: linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tang Bin , Zhang Shengju Subject: [PATCH 1/3] serial: 8250_ingenic: Use of_device_get_match_data Date: Sun, 22 Aug 2021 11:28:04 +0800 Message-Id: <20210822032806.3256-2-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 In-Reply-To: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> References: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Retrieve OF match data, it's better and cleaner to use 'of_device_get_match_data' over 'of_match_device'. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/tty/serial/8250/8250_ingenic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c index 988bf6bcc..65402d05e 100644 --- a/drivers/tty/serial/8250/8250_ingenic.c +++ b/drivers/tty/serial/8250/8250_ingenic.c @@ -209,16 +209,14 @@ static int ingenic_uart_probe(struct platform_device *pdev) struct uart_8250_port uart = {}; struct ingenic_uart_data *data; const struct ingenic_uart_config *cdata; - const struct of_device_id *match; struct resource *regs; int irq, err, line; - match = of_match_device(of_match, &pdev->dev); - if (!match) { + cdata = of_device_get_match_data(&pdev->dev); + if (!cdata) { dev_err(&pdev->dev, "Error: No device match found\n"); return -ENODEV; } - cdata = match->data; irq = platform_get_irq(pdev, 0); if (irq < 0) -- 2.20.1.windows.1