Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp824512pxb; Sat, 21 Aug 2021 20:34:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjKMqnPaRR57f10HpzOHL3P/pMTzqLlrqqiOTvq95203Kq/uzPBCzWxhop7QoJqTbUdXjU X-Received: by 2002:a17:906:1ec9:: with SMTP id m9mr30049261ejj.115.1629603270037; Sat, 21 Aug 2021 20:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629603270; cv=none; d=google.com; s=arc-20160816; b=qWy0+Q26yEo/Znyf+sIeAXqaQvO4Eoqt/4zfSX5OdGJzTGBknpTAppJztKgbzZrqkV JDCdQpotmTmgWZYFXSNMoiVWq5F8d8wbMD6Zq6/nvMy2GOJlM3AZ2wpdQd1C/B42PODr eodBX8m99GwIilCGlud4ySehtmBa0HEJmfW4EQExl8Cl/TuU41/yP9HxIv4kKIio4gEg QKVWuo9YL/HRgQ+zZLseeyDSwn1Qr91Pexw3RIHBVoy31a6gjUIytBr1Mlw1tDC2fmEY p5n3h8dmEN3+v1Ymb6IO5puPcl5/04ZvSOt0Uj4n4KY5Y1HNVxP4JyWWLLoy6GvOL6NU MLCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AM/6BK099zVUXzzNq69sNSpfrBXYERSbq5BsrMtYlZ0=; b=VFmslbZCG4KKXXTLhJwDNyvgYJAlaZEYKAOnPMGvmUTMY2glybLHf7C2nx47pvJXab 3K1dXpA9gB607dJ35y0kop3hnlEGNF/kuZFkRulXzUvgIaj+9w3PK9ho7VbNFioZDHQ6 PjQ0FZV+dquGBUZkRl0Ybh8FpG0mKqVgpGnOvjzAt7iGgMeVGE/OrmTx0HufBMRuIriW jJ33GHdnTP9qqib/0YhccEtdE3ZGJAUoLz0mLXAFJ845AvlJW2ofMh8dXrq8jCT7ZV6e RQWuNDkeiLtgYYvvhPs0phmARhcLbnrsa6eeQ3KoXU37wYYkO1R1wgYU8vL228WjIWFv AegA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si11147012edr.337.2021.08.21.20.34.07; Sat, 21 Aug 2021 20:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232593AbhHVD2n (ORCPT + 99 others); Sat, 21 Aug 2021 23:28:43 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:7990 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232417AbhHVD2l (ORCPT ); Sat, 21 Aug 2021 23:28:41 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.5]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee56121c432c31-f265f; Sun, 22 Aug 2021 11:27:47 +0800 (CST) X-RM-TRANSID: 2ee56121c432c31-f265f X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.22.250.151]) by rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id 2ee36121c429ec8-6521d; Sun, 22 Aug 2021 11:27:46 +0800 (CST) X-RM-TRANSID: 2ee36121c429ec8-6521d From: Tang Bin To: gregkh@linuxfoundation.org, paul@crapouillou.net, jirislaby@kernel.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux@prisktech.co.nz Cc: linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tang Bin , Zhang Shengju Subject: [PATCH 2/3] serial: tegra: Use of_device_get_match_data Date: Sun, 22 Aug 2021 11:28:05 +0800 Message-Id: <20210822032806.3256-3-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 In-Reply-To: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> References: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Retrieve OF match data, it's better and cleaner to use 'of_device_get_match_data' over 'of_match_device'. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/tty/serial/serial-tegra.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c index eba5b9ecb..45e2e4109 100644 --- a/drivers/tty/serial/serial-tegra.c +++ b/drivers/tty/serial/serial-tegra.c @@ -1568,14 +1568,12 @@ static int tegra_uart_probe(struct platform_device *pdev) struct resource *resource; int ret; const struct tegra_uart_chip_data *cdata; - const struct of_device_id *match; - match = of_match_device(tegra_uart_of_match, &pdev->dev); - if (!match) { + cdata = of_device_get_match_data(&pdev->dev); + if (!cdata) { dev_err(&pdev->dev, "Error: No device match found\n"); return -ENODEV; } - cdata = match->data; tup = devm_kzalloc(&pdev->dev, sizeof(*tup), GFP_KERNEL); if (!tup) { -- 2.20.1.windows.1