Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        Phillip Potter <phil@philpotter.co.uk>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect
Date:   Sun, 22 Aug 2021 13:06:09 +0200
Message-ID: <1821445.fzUCeO1EU3@localhost.localdomain>
In-Reply-To: <CAA=Fs0kByg1NztU+Nf__RUzTHuVh_q2hvcyh+3JqXiVgn+_VeQ@mail.gmail.com>
References: <YSFgrLUfXzgcT6k4@user> <CAA=Fs0kByg1NztU+Nf__RUzTHuVh_q2hvcyh+3JqXiVgn+_VeQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote:
> On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
> 
> <saurav.girepunje@gmail.com> wrote:
> > Remove the condition with no effect (if == else) in rtw_led.c
> > file.
> > 
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > 
> >  drivers/staging/r8188eu/core/rtw_led.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Thanks for this, looks good.
> 
> Acked-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Regards,
> Phil

Dear Philip,

Before acking, please check at least if it applies to the current version of 
the tree and check if it compiles without adding warnings and / or errors. :-)

Thanks,

Fabio