Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 22 Aug 2021 13:47:33 +0000
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
From:   Bryan Brattlof <hello@bryanbrattlof.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Reply-To: Bryan Brattlof <hello@bryanbrattlof.com>
Subject: Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()
Message-ID: <20210822134723.cuzzogvujokqiw3l@h510>
In-Reply-To: <2537053.yL3VPc0Jk4@localhost.localdomain>
References: <20210821235456.2502681-3-hello@bryanbrattlof.com> <2537053.yL3VPc0Jk4@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 22.08.2021 08:25, Fabio M. De Francesco wrote:
> On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> > The sdio_read_mem() function is unused. We can remove it.
> >
> > Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
> >  drivers/staging/rtl8723bs/include/rtw_io.h |  2 --
> >  2 files changed, 13 deletions(-)
>
> This change adds a build warning, which is not allowed.
>
> Please merge this, and the 4/6 patch into a single change, so that it
> all is removed together, causing no build warnings at any point in time.
>

Will do.

Thanks for the review, Fabio!
~Bryan

>
> thanks,
>
> Fabio
>
>
>