Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1152655pxb; Sun, 22 Aug 2021 07:30:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2vLV6mVu13etMA7RvDK0Sz1SwbYm82QotbmFa/jBKXi2nSbkkByo1x/leZV0VURHUvOIv X-Received: by 2002:a6b:8b4b:: with SMTP id n72mr22627359iod.18.1629642657061; Sun, 22 Aug 2021 07:30:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629642657; cv=none; d=google.com; s=arc-20160816; b=0SUuO0tG3V3IsdpVpdN5ToAnIwVub06sMDlPNJoA/HcicwmySZURuXFFNoTsRouggK AblSpCIU1WoaNuPPq0FZF4EcNpfYa3+G9Q95mzbncryfTjg1fWuKu7NVYZlil1XA8XO2 /eiAgqcpDBCiSjXhsrYMisNOr3c0DNGeFzSSMc1UNJg3IR265x6a9PJ7ttQ33X2FVil/ pJf22lm6D4uxe8XPxDcB9cIDnsru5rqunataN1lOywllLZWQlCIkSM20pv2m1MgBV/dg LFJRkqgZHbB5hCpNVJhhYRiswuWv0DLuNnTf+nedqPk72Lw9HoAlfRFMLsZZmLi4ZxgQ QJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vHQzlg8+BIlqPxnNxaMNoGbmoSkDfI9EpQFPZrKIu+0=; b=mZzRyENB3kTY1FBG56/W2ZoGTgXAMwl5KuFHhcVibD9BOHZznKSeGdlYs0cHx7hync gln/i6Cicj/R2hVKiYj2zAP9gTuxSDrBUJvaCVinbur2IYOcz0O4HVSm4Sfa+XjrsN9B 40tER0kLrLzRiE7puBtkARSIPgL5y9Bom8Dy3YyY0RKIh2+JncScwDxBQVSTaiFI3YSk rszB8FZt/M+8peTpNDP6OuMmwpnfEY+u6wfN2uOcFR3bgl79IyNM+CeJNcwCtKStE7jC VCZmjNt6Loxi6EqKETlulxImCgxGB3WR9ptU3H9z6nCeNsML7rHpat1E+ONstCv6fqb1 a4eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=OSHbHGWW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si13122482ilu.111.2021.08.22.07.30.20; Sun, 22 Aug 2021 07:30:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=OSHbHGWW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233450AbhHVO3o (ORCPT + 99 others); Sun, 22 Aug 2021 10:29:44 -0400 Received: from mout.gmx.net ([212.227.17.20]:45605 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhHVO3n (ORCPT ); Sun, 22 Aug 2021 10:29:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629642535; bh=OHoPvHMVl7ov+1IrCEJJ//cRmzfbOo3c5AVsORYPEEM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=OSHbHGWWTXRSroVGVp92KlmI/OCkdDPutmcELzdV8ELGo8XkP/ntB6DG34moM7n6h 3pQDsmWsIKY5+42K5MLyZiBALYoU/DI6EAGP8g3XDYBYqTSdgijIj5SDmAi0rBVQ0H FbFwWnkRj7eOXzQTFa/yjaV4oS/tuGxdZ0Ml4d3Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([79.150.72.99]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N7R1J-1n7rDe097d-017jRD; Sun, 22 Aug 2021 16:28:55 +0200 From: Len Baker To: Greg Kroah-Hartman Cc: Len Baker , Kees Cook , Michael Straube , Lee Jones , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH 0/2] staging/rtl8192u: Prefer kcalloc over open coded arithmetic Date: Sun, 22 Aug 2021 16:28:18 +0200 Message-Id: <20210822142820.5109-1-len.baker@gmx.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:p0IOLND2I4j+neza+y2pDeupbRTGH7itS5NwcdIdmzAMgBzpoZa 1L1WAy2w6dsSPIAxpglxWF60/GG34yMGkq46V4S8sW9sAR2jmHXcaECsIjxvC5u61wxyLQD lDfNHACysNucr5Psu9Bl8I0rSwPSWqcc9xeIcnYthZKG6XkDuQpsd/1qZPGQmE2E/Nh4CJZ QnP8LGfBfLSJOZIAFt1Iw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wlSf9zJTD58=:1TdS2kdpC92I63YFDzc43L bP/QUbnw5IJs+BbYDJEPe8Eyk2R6JXOcBiWua+oLCbAxzHJxqn35ux4kiALYo5+JMuJSHZWzT GrtrD6fAclOLsHLWm24iJEUV7GdCeZwMXkY29ktW2lhwbUrj4/oao5kR9yYppUlSnJmQ4Y15y 3OOVogKn6rokoyUJuqvJbyNuQ5L9oFXpg9iTzBhs5834vMhoi2c/u+pH8dVvTcsB+2kvF7fOr /IYYJtREPwJXiBi4hm7jXUOKDQL6w9aAzON4Yp3tGAJ5fReFAzBIOmv9rIDFA3TdT4fNWVwGP Lfiypv1a8mQdgknhvJPcW806uDrZO/AyOY/c4i7Btx77rd6GeTrrXhKapfz+BoP8nX7DF/lpz YAx0CzgljkA45i4qpJ0TdzEa4YKmx2/CvnnGDLt7oOzf/ZIYR6XEbT1Xc17l7ndIHAxt7BQfE IPwK6EerC6Yo4XHKnDQlywOxhSXKdo8ild7Pm9SYw0DldGcDcC12HN7xrYjfVtHjXkG9OqWIF ZlQsrcuZsIMNjy7r5YFx3KEsyAUPKHSg22qVFPmSSdT2cIZbhGZzC0VTs0YTaxXTKl2M2tkB3 RJ0TS3m0KawiHJcJE0/gF7RC4NyZ4LCCrerQBwcKZ27RpcUFzhqpuJkT4KWRYD394qcClWfiu VpnD8cEum8YUTyoUPclwxUf7wcD/wjaVvHTwnCLfd2h4PnkkkHUxUAZdh68Ddi94s5TbjX0Xn oXVkB+onZeR6h85hT4HY+jK/vK1AuaQyLi6RC1gUEpDrYCGgtuXhfqCW85hSMkFgsFkHmtWOq MOSW2q7EqZeha49rHlJ/qOtD28/CDmQ/L/x7TMn1BrJaSDGuSlyLPBnoLFP4gQXAT4uttJTGm Qon9tKpRfRGxtvljJWXM/e4sWejZTx7tEVeAeiZzv6YvBup42EFYOzxsq66PxO736rS3YH1R8 21OvqP2EFfp3DBOdodJVII9WDO8odKYHCnYMWLziSIn9B8gaQwfqEIL0mVLoRcqESQ3gx4ChB MmvTlLMFGEm1Old18S45B5SEQMYI2F7gQZ2+CUgxF23YmRY0rAYwjwQ2cm7ldcMk8HmAHZsfF pV3GAFOhAzgeAZI8fQkz+GLbEHzpQc5ZDF4PWojV/UCQrsVJOZuWeENNA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The main reason of this patch serie is to avoid dynamic size calculations (especially multiplication) in memory allocator function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. However, there is a previous patch to avoid CamelCase in the name of variables. Len Baker (2): staging/rtl8192u: Avoid CamelCase in names of variables staging/rtl8192u: Prefer kcalloc over open coded arithmetic drivers/staging/rtl8192u/r819xU_phy.c | 92 +++++++++++++-------------- 1 file changed, 44 insertions(+), 48 deletions(-) =2D- 2.25.1