Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1384727pxb; Sun, 22 Aug 2021 15:22:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyD128a+irs7VohKchfLuac+RD9i959ciy0CODXWbcBclZBlDhAxQbJhPAPvlKvzK2uBLxl X-Received: by 2002:a6b:e616:: with SMTP id g22mr24985405ioh.67.1629670924627; Sun, 22 Aug 2021 15:22:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629670924; cv=none; d=google.com; s=arc-20160816; b=w3GqD0+kbRbbb/xo2TMAOfA09LATVFFApgEeTCfmHonoi3c9fdDjRnfw3cUww5I7wB 4Eqe/9E8xT2385LFFWsfUf//APkRcJTwK+kufUqo2dFipvP7PEe28yX1FPCj1MtFEmPt b3L9kNJGuKsq1HjPBiDF4hVpbefNOly8eT9z84rvZeNHu9y19wvdGxkXnkhRUDw+HJ9X ySBTgKSKnJU8DDlz984A9/DA32StnfsRg+pU7bvb+uWpbmwOybzd49+F41l5BehfPXVS UWd1xX0le0P4b1KsC2yhfYNm0/8XZIRqDpT2K/8V78z6113Kyd6ltGwsX7opQoSWR50d 1QtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Vjgj6w+zbgn1146WXU3kPdkHix2wiSW7AS6QZB19vv0=; b=xoG4qo4vZs9MwPB0Ac/9lzFJUxnN019DTnc4S0t9CbUltGt1dtvj+BnyLOFBR+w7gY 48n41sbAwjV6FHS3EVG8NFyuy82EM5KnDeWcV4xcGgpudXYAzohj9zWlaqCJaPl3/fJ/ OPIuWK70y4lC50hpCNckx+qjcVdDz2K/Q54aSaGKrKBr5C7qZArlcdJID/GeKjopS82C 6fwmYsxb/5XJqCe6/nbsxfzH9zghqutehH/oRqRX9sL8Nif61bq6B2T1G7hgMP3dSuTk td7vuiGODzdOHsj+2F9JYsHuuXLXw7M2TvwJwgLCGQQ42kMEUTBURNIYHIEQQ4pwnR+g +ykA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=U1RHlD1x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si12702339ile.20.2021.08.22.15.21.53; Sun, 22 Aug 2021 15:22:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=U1RHlD1x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233417AbhHVWVB (ORCPT + 99 others); Sun, 22 Aug 2021 18:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbhHVWVA (ORCPT ); Sun, 22 Aug 2021 18:21:00 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C2AEC061575 for ; Sun, 22 Aug 2021 15:20:19 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso19978254ots.5 for ; Sun, 22 Aug 2021 15:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vjgj6w+zbgn1146WXU3kPdkHix2wiSW7AS6QZB19vv0=; b=U1RHlD1xBGXU36FLOnv0uEdvjekxmddM94p1l4+8iCvPqWge47JtmbvBWn1D9qthN9 ROAV55DeIpXnxg2d6w8rNYH12Gk+2nYASm/wLHpJQW3YThU7HyvkhVCw8TJEV7SlaSQ1 Lt1IFjhnsCASv+agnyd8oApkjCOD1XVHVFvktAIkkf8mF+Yxe44bGWQJSajiOYmcmS4f AuVWSmaFDiKjJy0a2YgJokSc+CVT3uapEwtyfWieztoWxAK5tVYxk5rzZrxO2tVBlGsR Jt9cH1NpMfklUdB70zID5PkMUHRgdKanql0papRHm6ZxDMGXoTMIZeYl4sasDNfF0asM ihPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vjgj6w+zbgn1146WXU3kPdkHix2wiSW7AS6QZB19vv0=; b=hq82jaA0dzgQ5ppBUW1SvtN863DgH65iEFDzSMNZui5rwIcRRJo7bIXwHSc2d40Roi HBvVsnrj1JhtmS2VndleMizIobuzQDdG3lagVn5ZW/my93V+pR9QQDq8lZCwV/SIqpFb p6lK7vs6zE9/pl683yujQGu/+3OGEEl/ZHkQeJf6vYom8Y/iiupnwOBqL95KXyahBYz8 amBpFk+c2ta77Y1oigvOGku2NZwtoTjjWXQXJw25RwtsUbKD1RdjxpVBrxItpGvTM4Ro 0j8CCPGD8H/FovMoMsDoS6Vwhlh9JZrNZSqARe3YJyOf11AFKcEg9IfZOUYpuNvG3YnQ DlvQ== X-Gm-Message-State: AOAM5328i3xIYEMrIBCiGyWxeJDx+VeAMOcIWdsPvzICoX9P+Zqryxn3 tIdNXfq4hPpJjKJIEoVHjtc= X-Received: by 2002:a9d:5f16:: with SMTP id f22mr24670188oti.322.1629670818575; Sun, 22 Aug 2021 15:20:18 -0700 (PDT) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id x198sm2964122ooa.43.2021.08.22.15.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Aug 2021 15:20:18 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, seanpaul@chromium.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie Subject: [PATCH v6 00/11] use DYNAMIC_DEBUG to implement DRM.debug Date: Sun, 22 Aug 2021 16:19:58 -0600 Message-Id: <20210822222009.2035788-1-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset does 3 main things. Adds DEFINE_DYNAMIC_DEBUG_CATEGORIES to define bitmap => category control of pr_debugs, and to create their sysfs entries. Uses it in amdgpu, i915 to control existing pr_debugs according to their ad-hoc categorizations. Plugs dyndbg into drm-debug framework, in a configurable manner. v6: cleans up per v5 feedback, and adds RFC stuff: - test_dynamic_debug.ko: uses tracer facility added in v5:8/9 - prototype print-once & rate-limiting Hopefully adding RFC stuff doesnt distract too much. Jim Cromie (11): moduleparam: add data member to struct kernel_param dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs drm_print: add choice to use dynamic debug in drm-debug drm_print: instrument drm_debug_enabled amdgpu_ucode: reduce number of pr_debug calls nouveau: fold multiple DRM_DEBUG_DRIVERs together dyndbg: RFC add debug-trace callback, selftest with it. RFC dyndbg: RFC add print-once and print-ratelimited features. RFC. drivers/gpu/drm/Kconfig | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 293 ++++++++------- .../gpu/drm/amd/display/dc/core/dc_debug.c | 44 ++- drivers/gpu/drm/drm_print.c | 49 ++- drivers/gpu/drm/i915/gvt/Makefile | 4 + drivers/gpu/drm/i915/gvt/debug.h | 18 +- drivers/gpu/drm/i915/i915_params.c | 35 ++ drivers/gpu/drm/nouveau/nouveau_drm.c | 36 +- include/drm/drm_print.h | 148 ++++++-- include/linux/dynamic_debug.h | 81 ++++- include/linux/moduleparam.h | 11 +- lib/Kconfig.debug | 11 + lib/Makefile | 1 + lib/dynamic_debug.c | 336 ++++++++++++++++-- lib/test_dynamic_debug.c | 279 +++++++++++++++ 15 files changed, 1117 insertions(+), 242 deletions(-) create mode 100644 lib/test_dynamic_debug.c -- 2.31.1