Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ChiaWei Wang <chiawei_wang@aspeedtech.com>
To:     Rob Herring <robh@kernel.org>
CC:     "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ryan Chen <ryan_chen@aspeedtech.com>
Subject: RE: [PATCH v2 1/5] dt-bindings: aspeed: Add eSPI controller
Thread-Topic: [PATCH v2 1/5] dt-bindings: aspeed: Add eSPI controller
Thread-Index: AQHXlNBwicwOSKJ0Y0KdC4J0I1p936t80tKAgAN7vTA=
Date:   Mon, 23 Aug 2021 01:21:15 +0000
Message-ID: <HK0PR06MB3779C39208BDFEB6A80006AF91C49@HK0PR06MB3779.apcprd06.prod.outlook.com>
References: <20210819080040.31242-1-chiawei_wang@aspeedtech.com>
 <20210819080040.31242-2-chiawei_wang@aspeedtech.com>
 <YSAKM16WLx4UWIQu@robh.at.kernel.org>
In-Reply-To: <YSAKM16WLx4UWIQu@robh.at.kernel.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0cmAKflwu6ybCDOuBLxvPGkLL22920wch9zCnhbJQ0tSr89/n4vuHzlOq8yJ?=
 =?us-ascii?Q?PB+WKlZMpD/vrfjkEaoH4P8cVH4YYoddNhDj4dvq+eeuULjecAagHW6bG9F3?=
 =?us-ascii?Q?qGF0z1XJY5uNmn8TMJRHlnGcHdVHJ5lMHKWGF070JPi3eaVRErNKuU2eiv1b?=
 =?us-ascii?Q?Im0V5Ftirxflzz7BpNwOhNSZ2NObUgRBxSMffJsQSdBIJIkWTDE02LCwk8TR?=
 =?us-ascii?Q?uhKrb9iO3FAHjJCqWkD3CSZQ8Pv+Nuc5g5s7ph5sLjPY+bIPrjb6+ZiKLrOg?=
 =?us-ascii?Q?07Wuf9ujHWRxcfAK6LRM1Jf3CMs2O7rQrPpbhjek8AW2CWZbmVtSUSF5SjCg?=
 =?us-ascii?Q?J21Te4x0gyRCFGS7dILtslrt7is0SeGoYFqubSPYIycdp/Sbrra8RW6RaCcT?=
 =?us-ascii?Q?8Qm7hKBwkavXjSgne7remUjLjeanpbyfMhmEDM6tTiGpocFFvBIDw0oIs6P9?=
 =?us-ascii?Q?u4OsUZJeym46BOQs0ursBGxtON9uK/dUh9ZvbYV+q9IZGyJK0eoFceIE7CBH?=
 =?us-ascii?Q?sMdRMZkLVc1S4rpYrMKlFdJKQbk2W99SvOscBK2cKxyMXhK5qTKJ42UqvAcH?=
 =?us-ascii?Q?btuYMSNb8wSEhXMqQzvynznycZFfH4x466Fb5nUB5IuaF3IZ27KfpTqIJTzV?=
 =?us-ascii?Q?hqmkOpvhlRPs03Nu5IhVGwjN5kqDPFIBEbwuZpvEyXph2jDdS3l9j9IiadW7?=
 =?us-ascii?Q?P71AlB73cffIDjyfcS+vLT8c6ZYHAZRZf1dOvkcjnlsdV/i1MvreDbMrYk8a?=
 =?us-ascii?Q?08fjgs6Pn8p3Zr3KuD/UKsn9gSlUQNvzUSzjXAmLATRIuJiy458aBRRs4WVz?=
 =?us-ascii?Q?GF99nPZlVfIjkiaZ2o1WwJfTWCA0lvcuvvb/oSz63gfqiRJnTOmYYUtF4uBp?=
 =?us-ascii?Q?tPOD3DPdFn708T1Q0DKyvf7kzJhjL+ysCkBBchFuCeVESKEF8MIMIXj1Kbz0?=
 =?us-ascii?Q?QgLIwXjQkjgFSZHUjvDydTB04DUPXUzWhw+vhmBqG1VxRlYmkQiJNWvvEcqP?=
 =?us-ascii?Q?AyLZfuYpxg2fZa7xuM7e9uQ052adrYrp/3LNuZTcusQdEKKhlL/S2BoB7geU?=
 =?us-ascii?Q?hfmXk9iq2C4p5ZM+u9zqN0GAMbS0pMabcmQ18qAjVnzED+iMtliSYtAZxnym?=
 =?us-ascii?Q?Sj97/TTb9NQErdXibFhTKI43XjnLf33Mi/6LHR2bnWOzuqiujdke8B3QVcVR?=
 =?us-ascii?Q?5YYNzIMeWFAbIjgQbXR5nKRid9Moj4cLT7Pg9Suc9C85TCQ1hANNEZ071Yt6?=
 =?us-ascii?Q?WAUFl7bG6z+kZuosAju13px2eAUOmOM32/EQmCp6+oP6d7Kc03ecBtpl0fqX?=
 =?us-ascii?Q?2XMzJfgvSyhTyLVI4WWaj1J9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3779.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91f6c2dd-874b-41cb-9c65-08d965d44d6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 01:21:15.5198
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5CFGj87laOhuNQGpikQ6EN46sR3uBY3AtCr5g5CVPhFv7ittqWn7/ZK3reQpC0YPqwyw62uhrmJ38beN+W0MlruLsL3Q3swS+yBLNQYIx9w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1828
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Saturday, August 21, 2021 4:02 AM
> To: ChiaWei Wang <chiawei_wang@aspeedtech.com>
> Cc: joel@jms.id.au; andrew@aj.id.au; linux-aspeed@lists.ozlabs.org;
> openbmc@lists.ozlabs.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ryan =
Chen
> <ryan_chen@aspeedtech.com>
> Subject: Re: [PATCH v2 1/5] dt-bindings: aspeed: Add eSPI controller
>=20
> On Thu, Aug 19, 2021 at 04:00:36PM +0800, Chia-Wei Wang wrote:
> > Add dt-bindings for Aspeed eSPI controller
> >
> > Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > ---
> >  .../devicetree/bindings/soc/aspeed/espi.yaml  | 158
> > ++++++++++++++++++
> >  1 file changed, 158 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/soc/aspeed/espi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/soc/aspeed/espi.yaml
> > b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml
> > new file mode 100644
> > index 000000000000..fec3d37f3ffd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml
> > @@ -0,0 +1,158 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # #
> > +Copyright (c) 2021 Aspeed Technology Inc.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/soc/aspeed/espi.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Aspeed eSPI Controller
> > +
> > +maintainers:
> > +  - Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > +  - Ryan Chen <ryan_chen@aspeedtech.com>
> > +
> > +description:
> > +  Aspeed eSPI controller implements a slave side eSPI endpoint device
> > +  supporting the four eSPI channels, namely peripheral, virtual wire,
> > +  out-of-band, and flash.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - aspeed,ast2500-espi
> > +          - aspeed,ast2600-espi
> > +      - const: simple-mfd
> > +      - const: syscon
>=20
> Is this really 2 sub devices that could be used individually or in a diff=
erent
> combination? If not, then I'd make all this 1 node.

espi-mmbi has individual function and control registers.
However, espi-mmbi is also a feature extended based on the memory cycle of =
eSPI peripheral channel.
Thereby, it has dependency on the eSPI channel initialization conducted by =
espi-ctrl.
The scenario is similar to the lpc-ctrl and other lpc-xxx drivers of Aspeed=
 SoCs.

Chiawei