Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1670630pxb; Mon, 23 Aug 2021 01:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzASfU0I3wpY1BZx4zot5YSrKQ/kezND0+7qjLRPAzzvg18ZfCRFmTro2yVG1QecdUdkFp7 X-Received: by 2002:a17:907:2123:: with SMTP id qo3mr34482362ejb.277.1629707644205; Mon, 23 Aug 2021 01:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629707644; cv=none; d=google.com; s=arc-20160816; b=DJIuirj8CQ4+7zEaSbMiN+aUJ4q5lqgZMIvHeRjwVtj8Ry8jrJe+RpG+QCE5xowV5r ZdXMBOqvDlku1cuXtd7bbLgIGE+oq4gaeJGxaCf4ByHzvvECZQvQAQXNA1suVYKlJoOb f7uxIGqdicNlEs8DXTzFsJLH7l+BKgSbPBFmH7uNbnqzPvgXjftCBbOVWEBGeWrg6Nv9 Klkr3ybxdoKhhHE8dpIpViSMQxYIzlfxXuh3viP1xnQIJjwFnS6xUnfWU42OjPAaVJJl 80zKivBdiclshSI3junxFeuJ1Nf+m95LBV7BuDcIHSXIEcPmPz7DkLt8IWQUPeALeoDk Y8+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=mTEV8cL79qi1UYqm1S5ZWXY9k4QApnHRrHWo2C9/gM0=; b=tolMn8c2qr6BvlmKshiLAXBjdiTFImgKOlE1Di5eslTpsQPdinJFRPl5JmneM/ExUk 2UFtj3pKqSKzWksBq6iBfuCPaJUVjWNHbEoAhZwhrW3lk832lQ5gufa3XVeB0ngEqCb5 UZ77JFm7/FeJvtAtL8ve4kR9zzy8KrgNv014Z2Ggi3O3dd9bp/vo5Y13+Zo0272ZFfcA sWlyZti2x+hTL62FGBqvU/OHUKX2rMxI4akRKMnInjfDAwpuDRJIk1sXt4p5gJcpFncs PF3+MoDUFx+gduvhPYjhfCqetYWnW+QUkWulP1Un2qQ3EBcFjNmdO25WNyJH9rgMN++l K/Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l17si13878763ejn.343.2021.08.23.01.33.41; Mon, 23 Aug 2021 01:34:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbhHWIap (ORCPT + 99 others); Mon, 23 Aug 2021 04:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235460AbhHWIan (ORCPT ); Mon, 23 Aug 2021 04:30:43 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C7A6C061575; Mon, 23 Aug 2021 01:30:01 -0700 (PDT) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:4cb:a870:648a:6e9d:d5af:13ed]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AFEA21F42270; Mon, 23 Aug 2021 09:29:58 +0100 (BST) From: Benjamin Gaignard To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, jc@kynesim.co.uk, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH] media: hevc: fix pictures lists type Date: Mon, 23 Aug 2021 10:29:49 +0200 Message-Id: <20210823082949.237716-1-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The lists embedded Picture Order Count values which are s32 so their type most be s32 and not u8. Reported-by: John Cox Signed-off-by: Benjamin Gaignard --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 6 +++--- include/media/hevc-ctrls.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst index 976d34445a24..db9859ddc8b2 100644 --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst @@ -3323,15 +3323,15 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - * - __u8 - ``num_poc_lt_curr`` - The number of reference pictures in the long-term set. - * - __u8 + * - __s32 - ``poc_st_curr_before[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]`` - PocStCurrBefore as described in section 8.3.2 "Decoding process for reference picture set. - * - __u8 + * - __s32 - ``poc_st_curr_after[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]`` - PocStCurrAfter as described in section 8.3.2 "Decoding process for reference picture set. - * - __u8 + * - __s32 - ``poc_lt_curr[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]`` - PocLtCurr as described in section 8.3.2 "Decoding process for reference picture set. diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h index 781371bff2ad..04cd62e77f25 100644 --- a/include/media/hevc-ctrls.h +++ b/include/media/hevc-ctrls.h @@ -219,9 +219,9 @@ struct v4l2_ctrl_hevc_decode_params { __u8 num_poc_st_curr_before; __u8 num_poc_st_curr_after; __u8 num_poc_lt_curr; - __u8 poc_st_curr_before[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; - __u8 poc_st_curr_after[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; - __u8 poc_lt_curr[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; + __s32 poc_st_curr_before[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; + __s32 poc_st_curr_after[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; + __s32 poc_lt_curr[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; __u64 flags; }; -- 2.25.1