Message-ID: <45747BF6.9090502@oracle.com>
Date: Mon, 04 Dec 2006 11:50:14 -0800
From: Zach Brown <zach.brown@oracle.com>
User-Agent: Thunderbird 1.5.0.8 (X11/20061107)
MIME-Version: 1.0
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
CC: Andrew Morton <akpm@osdl.org>, linux-kernel <linux-kernel@vger.kernel.org>,
       Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch] remove redundant iov segment check
References: <000401c717dc$bff0c5e0$2589030a@amr.corp.intel.com>
In-Reply-To: <000401c717dc$bff0c5e0$2589030a@amr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 913
Lines: 21


> Maybe we should create another internal generic_file_aio_read/write
> for in-core function? fs/read_write.c and fs/aio.c are not module-able
> and the check is already there.  For external module, we can do the
> check and then calls down to the internal one.

Maybe.  I'd rather see fewer moving parts here, not more.

> I hate to see iov is being walked multiple times ....

Indeed, hence the desire to walk it once and pass down a summary of the
results in an explicit struct.  The patch in this thread removes one
redundancy, but there are many.  I think I counted 6 iovec walks in some
path?  I can't remember which.  I'd rather tackle them all in one go.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/